chromeos: Add suspend delay tests for PowerManagerClient.

chromeos: Add suspend delay tests for PowerManagerClient.

Add initial unit tests for chromeos::PowerManagerClient's
suspend-delay-handling code. More coming soon.

BUG=646912
Committed: https://crrev.com/751cb04fca2fb7861de5ad396d2b08f18471fa9a
Cr-Commit-Position: refs/heads/master@{#418716}

[Daniel Erat, 2016-09-14 22:16:26]

derat@chromium.org changed reviewers:
+ chirantan@chromium.org

[Daniel Erat, 2016-09-14 22:16:31]

The CQ bit was checked by derat@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 22:16:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Erat, 2016-09-14 22:23:53]

The CQ bit was unchecked by derat@chromium.org

[Daniel Erat, 2016-09-14 22:24:16]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2016-09-14 22:24:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 22:24:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 22:24:41]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Daniel Erat, 2016-09-14 22:25:25]

The CQ bit was unchecked by derat@chromium.org

[Daniel Erat, 2016-09-14 22:25:30]

The CQ bit was checked by derat@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 22:26:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Chirantan Ekbote, 2016-09-14 22:31:30]

lgtm

https://codereview.chromium.org/2345593002/diff/20001/chromeos/dbus/power_man...
File chromeos/dbus/power_manager_client_unittest.cc (right):

https://codereview.chromium.org/2345593002/diff/20001/chromeos/dbus/power_man...
chromeos/dbus/power_manager_client_unittest.cc:133:
TestDelegate(PowerManagerClient* client) : weak_ptr_factory_(this) {
explicit?

https://codereview.chromium.org/2345593002/diff/20001/chromeos/dbus/power_man...
chromeos/dbus/power_manager_client_unittest.cc:218: void
EmitSuspendImminentSignal(const std::string& signal_name,
So far all callers of this function pass in kSuspendImminent but I assume this
is a separate parameter so that we can change the signal to dark suspend
imminent in some callers?

[Daniel Erat, 2016-09-14 22:42:13]

thanks for the quick review!

https://codereview.chromium.org/2345593002/diff/20001/chromeos/dbus/power_man...
File chromeos/dbus/power_manager_client_unittest.cc (right):

https://codereview.chromium.org/2345593002/diff/20001/chromeos/dbus/power_man...
chromeos/dbus/power_manager_client_unittest.cc:133:
TestDelegate(PowerManagerClient* client) : weak_ptr_factory_(this) {
On 2016/09/14 22:31:30, Chirantan Ekbote wrote:
> explicit?

whoops, yes. thanks.

https://codereview.chromium.org/2345593002/diff/20001/chromeos/dbus/power_man...
chromeos/dbus/power_manager_client_unittest.cc:218: void
EmitSuspendImminentSignal(const std::string& signal_name,
On 2016/09/14 22:31:30, Chirantan Ekbote wrote:
> So far all callers of this function pass in kSuspendImminent but I assume this
> is a separate parameter so that we can change the signal to dark suspend
> imminent in some callers?

yep, exactly. i'll mention dark suspend in the TODO as well.

[Daniel Erat, 2016-09-14 22:42:20]

The CQ bit was checked by derat@chromium.org

[Daniel Erat, 2016-09-14 22:42:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
chirantan@chromium.org
Link to the patchset: https://codereview.chromium.org/2345593002/#ps40001
(title: "address review comments")

[commit-bot: I haz the power, 2016-09-14 22:42:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 23:57:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-15 00:00:02]

Description was changed from

==========
chromeos: Add suspend delay tests for PowerManagerClient.

Add initial unit tests for chromeos::PowerManagerClient's
suspend-delay-handling code. More coming soon.

BUG=646912
==========

to

==========
chromeos: Add suspend delay tests for PowerManagerClient.

Add initial unit tests for chromeos::PowerManagerClient's
suspend-delay-handling code. More coming soon.

BUG=646912

Committed: https://crrev.com/751cb04fca2fb7861de5ad396d2b08f18471fa9a
Cr-Commit-Position: refs/heads/master@{#418716}
==========

[commit-bot: I haz the power, 2016-09-15 00:00:03]

Patchset 3 (id:??) landed as
https://crrev.com/751cb04fca2fb7861de5ad396d2b08f18471fa9a
Cr-Commit-Position: refs/heads/master@{#418716}