Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2345553002: Revert of Roll isolate go to binaries as generated by infra @ 6f3db5a82956. (Closed)

Created:
4 years, 3 months ago by jam
Modified:
4 years, 3 months ago
CC:
chromium-reviews, tandrii(chromium)
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll isolate go to binaries as generated by infra @ 6f3db5a82956. (patchset #1 id:1 of https://codereview.chromium.org/2256093002/ ) Reason for revert: This is causing isolate step to be much slower per https://bugs.chromium.org/p/chromium/issues/detail?id=644410 Original issue's description: > Roll isolate go to binaries as generated by infra @ 6f3db5a82956. > > Which is luci-go @ e438e8c3b563e48aaccca7bd0f4997ef29174e3d > > TBR=tansell@chromium.org > BUG=598990 > > Committed: https://crrev.com/a7ce77dda519428ce58039382485c7cd0cc05ab7 > Cr-Commit-Position: refs/heads/master@{#412819} TBR=tansell@chromium.org,tandrii@chromium.org,maruel@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=598990

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/luci-go/linux64/isolate.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/luci-go/mac64/isolate.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/luci-go/win64/isolate.exe.sha1 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
jam
Created Revert of Roll isolate go to binaries as generated by infra @ 6f3db5a82956.
4 years, 3 months ago (2016-09-14 19:17:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345553002/1
4 years, 3 months ago (2016-09-14 19:18:36 UTC) #3
jam
4 years, 3 months ago (2016-09-14 19:36:44 UTC) #4
ah this was already reverted in https://codereview.chromium.org/2344563003/

Powered by Google App Engine
This is Rietveld 408576698