Fully polyfill KeyEvent so that you can programmatically create your own "keyboard" events.

Fully polyfill KeyEvent so that you can programmatically create your own "keyboard" events.

Added some test cases as well.


BUG=
R=sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28321

[Emily Fortuna, 2013-09-04 00:08:07]

This should be the last of the Key(board)Event work, and hopefully put a lid on
that for a while.

https://codereview.chromium.org/23455033/diff/4001/tools/dom/src/KeyName.dart
File tools/dom/src/KeyName.dart (right):

https://codereview.chromium.org/23455033/diff/4001/tools/dom/src/KeyName.dart...
tools/dom/src/KeyName.dart:12: abstract class _KeyName {
this was only used when associated with KeyIdentifier. Since I removed
keyIdentifier from the KeyboardEvent class (it's only on (current and former)
webkit browsers), this shouldn't be user visible anywhere.

https://codereview.chromium.org/23455033/diff/4001/tools/dom/src/dart2js_KeyE...
File tools/dom/src/dart2js_KeyEvent.dart (right):

https://codereview.chromium.org/23455033/diff/4001/tools/dom/src/dart2js_KeyE...
tools/dom/src/dart2js_KeyEvent.dart:111: var record =
makeLeafDispatchRecord(interceptor);
Stephen and I worked on this wackiness. It was the option we were able to
develop for the situation.

[Emily Fortuna, 2013-09-09 18:08:12]

ping..

[blois, 2013-09-09 21:13:14]

https://codereview.chromium.org/23455033/diff/4001/tools/dom/src/dart2js_KeyE...
File tools/dom/src/dart2js_KeyEvent.dart (right):

https://codereview.chromium.org/23455033/diff/4001/tools/dom/src/dart2js_KeyE...
tools/dom/src/dart2js_KeyEvent.dart:62: if (view == null) {
If this event cannot be dispatched, why not have a private class which
implements the interface rather than wraps, and just return that?

https://codereview.chromium.org/23455033/diff/4001/tools/dom/src/dart2js_KeyE...
tools/dom/src/dart2js_KeyEvent.dart:110: var interceptor = new
KeyboardEvent._private();
Is there any way to use the JS constructor to get this rather than adding this
constructor?

[strom, 2013-09-12 15:42:41]

https://codereview.chromium.org/23455033/diff/4001/tools/dom/src/EventStreamP...
File tools/dom/src/EventStreamProvider.dart (right):

https://codereview.chromium.org/23455033/diff/4001/tools/dom/src/EventStreamP...
tools/dom/src/EventStreamProvider.dart:101: void add(T event);
I understand using add() here, especially since it has the same signature as the
EventSink version. Still, I would imagine that it would be confusing to some
since you need a stream controller/sink everywhere else.

Maybe dispatch?

KeyEvent.
  keyPressEvent.
  forTarget(document.body).
  dispatch(new KeyEvent(...));

[Emily Fortuna, 2013-10-04 23:41:29]

Please take another look. Adjusted based on comments discussed offline. Added
the dispatch and added a test to make sure this is happening.

https://codereview.chromium.org/23455033/diff/4001/tools/dom/src/dart2js_KeyE...
File tools/dom/src/dart2js_KeyEvent.dart (right):

https://codereview.chromium.org/23455033/diff/4001/tools/dom/src/dart2js_KeyE...
tools/dom/src/dart2js_KeyEvent.dart:110: var interceptor = new
KeyboardEvent._private();
On 2013/09/09 21:13:15, blois wrote:
> Is there any way to use the JS constructor to get this rather than adding this
> constructor?

No. Stephen and I worked on this, and this was the best option we could get. We
want it to point to the Dart version of the KeyboardEvent, not the JS type,
because we want it to be an interceptor for the *Dart* KeyboardEvent type, not
the underlying JS.

[sra1, 2013-10-07 17:47:11]

https://codereview.chromium.org/23455033/diff/4001/tools/dom/src/dart2js_KeyE...
File tools/dom/src/dart2js_KeyEvent.dart (right):

https://codereview.chromium.org/23455033/diff/4001/tools/dom/src/dart2js_KeyE...
tools/dom/src/dart2js_KeyEvent.dart:110: var interceptor = new
KeyboardEvent._private();
On 2013/10/04 23:41:30, Emily Fortuna wrote:
> On 2013/09/09 21:13:15, blois wrote:
> > Is there any way to use the JS constructor to get this rather than adding
this
> > constructor?
> 
> No. Stephen and I worked on this, and this was the best option we could get.
We
> want it to point to the Dart version of the KeyboardEvent, not the JS type,
> because we want it to be an interceptor for the *Dart* KeyboardEvent type, not
> the underlying JS.

It would certainly be handy to have a special way of getting the interceptor for
a
class.  I have opened Issue 13873 to track.

Are there other places where we want to make an instance 'be' a specific class?

https://codereview.chromium.org/23455033/diff/27002/tools/dom/src/dart2js_Key...
File tools/dom/src/dart2js_KeyEvent.dart (right):

https://codereview.chromium.org/23455033/diff/27002/tools/dom/src/dart2js_Key...
tools/dom/src/dart2js_KeyEvent.dart:120: var interceptor = new
KeyboardEvent._private();
Add: TODO(13873): Use better way to get interceptor and remove _private()
constructors.

https://codereview.chromium.org/23455033/diff/27002/tools/dom/src/dart2js_Key...
tools/dom/src/dart2js_KeyEvent.dart:121: var record =
makeLeafDispatchRecord(interceptor);
We could make 'record' a static final so we create the dispatch record only
once.

static final _KeyboardEventDispatchRecord = _makeRecord();
_makeRecord() {
  var interceptor = new KeyboardEvent._private();
  return makeLeafDispatchRecord(interceptor);
}

setDispatchProperty(eventObj, _KeyboardEventDispatchRecord);

https://codereview.chromium.org/23455033/diff/27002/tools/dom/src/dart2js_Key...
tools/dom/src/dart2js_KeyEvent.dart:134: '&& document.body.dispatchEvent.length
> 0');
Better to have an argument that is multiline not share a line with another
argument:

    JS('bool',
        '(typeof document.body.dispatchEvent == "function")'
        ' && document.body.dispatchEvent.length > 0');

[Emily Fortuna, 2013-10-07 18:43:03]

ptal

https://codereview.chromium.org/23455033/diff/4001/tools/dom/src/dart2js_KeyE...
File tools/dom/src/dart2js_KeyEvent.dart (right):

https://codereview.chromium.org/23455033/diff/4001/tools/dom/src/dart2js_KeyE...
tools/dom/src/dart2js_KeyEvent.dart:110: var interceptor = new
KeyboardEvent._private();
On 2013/10/07 17:47:11, sra1 wrote:
> On 2013/10/04 23:41:30, Emily Fortuna wrote:
> > On 2013/09/09 21:13:15, blois wrote:
> > > Is there any way to use the JS constructor to get this rather than adding
> this
> > > constructor?
> > 
> > No. Stephen and I worked on this, and this was the best option we could get.
> We
> > want it to point to the Dart version of the KeyboardEvent, not the JS type,
> > because we want it to be an interceptor for the *Dart* KeyboardEvent type,
not
> > the underlying JS.
> 
> It would certainly be handy to have a special way of getting the interceptor
for
> a
> class.  I have opened Issue 13873 to track.
> 
> Are there other places where we want to make an instance 'be' a specific
class?

Haven't run into other instances just yet, but I can certainly see that being
handy for when users want to create their own custom events that behave
similarly to "real" events.

https://codereview.chromium.org/23455033/diff/27002/tools/dom/src/dart2js_Key...
File tools/dom/src/dart2js_KeyEvent.dart (right):

https://codereview.chromium.org/23455033/diff/27002/tools/dom/src/dart2js_Key...
tools/dom/src/dart2js_KeyEvent.dart:120: var interceptor = new
KeyboardEvent._private();
On 2013/10/07 17:47:11, sra1 wrote:
> Add: TODO(13873): Use better way to get interceptor and remove _private()
> constructors.

Done.

https://codereview.chromium.org/23455033/diff/27002/tools/dom/src/dart2js_Key...
tools/dom/src/dart2js_KeyEvent.dart:121: var record =
makeLeafDispatchRecord(interceptor);
On 2013/10/07 17:47:11, sra1 wrote:
> We could make 'record' a static final so we create the dispatch record only
> once.
> 
> static final _KeyboardEventDispatchRecord = _makeRecord();
> _makeRecord() {
>   var interceptor = new KeyboardEvent._private();
>   return makeLeafDispatchRecord(interceptor);
> }
> 
> setDispatchProperty(eventObj, _KeyboardEventDispatchRecord);

Done.

https://codereview.chromium.org/23455033/diff/27002/tools/dom/src/dart2js_Key...
tools/dom/src/dart2js_KeyEvent.dart:134: '&& document.body.dispatchEvent.length
> 0');
On 2013/10/07 17:47:11, sra1 wrote:
> Better to have an argument that is multiline not share a line with another
> argument:
> 
>     JS('bool',
>         '(typeof document.body.dispatchEvent == "function")'
>         ' && document.body.dispatchEvent.length > 0');

Done.

[sra1, 2013-10-07 18:46:10]

lgtm

https://codereview.chromium.org/23455033/diff/51001/tools/dom/src/dart2js_Key...
File tools/dom/src/dart2js_KeyEvent.dart (right):

https://codereview.chromium.org/23455033/diff/51001/tools/dom/src/dart2js_Key...
tools/dom/src/dart2js_KeyEvent.dart:59: // TODO(efortuna): Use better way to get
interceptor and remove _private()
I'd make this TODO(13873)

[Emily Fortuna, 2013-10-07 19:29:05]

https://codereview.chromium.org/23455033/diff/51001/tools/dom/src/dart2js_Key...
File tools/dom/src/dart2js_KeyEvent.dart (right):

https://codereview.chromium.org/23455033/diff/51001/tools/dom/src/dart2js_Key...
tools/dom/src/dart2js_KeyEvent.dart:59: // TODO(efortuna): Use better way to get
interceptor and remove _private()
On 2013/10/07 18:46:10, sra1 wrote:
> I'd make this TODO(13873)

Okay. Just curious, when did this format change? Florian was using this format,
too, but I thought the TODO(username) was the standard.

[Emily Fortuna, 2013-10-07 19:40:25]

Committed patchset #3 manually as r28321 (presubmit successful).