Issue 23455020: file_manager: IsFallbackFileBrowserHandler() to take TaskDescriptor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23455020: file_manager: IsFallbackFileBrowserHandler() to take TaskDescriptor (Closed)

Created:
7 years, 3 months ago by satorux1

Modified:
7 years, 3 months ago

Reviewers:
kinaba

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

file_manager: IsFallbackFileBrowserHandler() to take TaskDescriptor This is in preparation of reworking the default task selection logic. This function will be needed from a place where FileBrowserHandler pointers are not present. BUG=282109 TEST=none R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220530

Patch Set 1 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -17 lines)			Patch
M	chrome/browser/chromeos/extensions/file_manager/file_browser_handlers.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/file_browser_handlers.cc	View	3 chunks	+10 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/open_util.cc	View	1 chunk	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

satorux1

7 years, 3 months ago (2013-08-30 07:22:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r220530 (presubmit successful).

Expand Messages | Collapse Messages