Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/open_util.cc

Issue 23455020: file_manager: IsFallbackFileBrowserHandler() to take TaskDescriptor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/file_browser_handlers.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/file_manager/open_util.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/open_util.cc b/chrome/browser/chromeos/extensions/file_manager/open_util.cc
index 4f194eb31fb088250ca5935fd282bf3d3b289739..d3f9bbafc5746fbc8ff11b9db941a6766a16b8a8 100644
--- a/chrome/browser/chromeos/extensions/file_manager/open_util.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/open_util.cc
@@ -244,12 +244,14 @@ bool OpenFileWithHandler(Profile* profile, const base::FilePath& file_path) {
profile, file_path, url, mime_type, default_task_id);
}
- std::string handler_task_id = file_tasks::MakeTaskID(
- handler->extension_id(),
- file_tasks::TASK_TYPE_FILE_BROWSER_HANDLER,
- handler->id());
+ const file_tasks::TaskDescriptor task_descriptor(
+ handler->extension_id(),
+ file_tasks::TASK_TYPE_FILE_BROWSER_HANDLER,
+ handler->id());
+ const std::string handler_task_id =
+ file_tasks::TaskDescriptorToId(task_descriptor);
if (handler_task_id != default_task_id &&
- !file_browser_handlers::IsFallbackFileBrowserHandler(handler) &&
+ !file_browser_handlers::IsFallbackFileBrowserHandler(task_descriptor) &&
OpenFileWithFileHandler(
profile, file_path, url, mime_type, default_task_id)) {
return true;
« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/file_browser_handlers.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698