Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2345483002: [scheduler] Throttle background frames with 1% CPU limit (Closed)

Created:
4 years, 3 months ago by altimin
Modified:
4 years, 2 months ago
CC:
blink-reviews, chromium-reviews, scheduler-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[scheduler] Throttle background frames with 1% CPU limit BUG=639852, 653865 Committed: https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da Committed: https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22 Committed: https://crrev.com/1fca2bed4bacd6fb1dc7ffacd4c2d92d59ceae8f Cr-Original-Original-Commit-Position: refs/heads/master@{#423170} Cr-Original-Commit-Position: refs/heads/master@{#423604} Cr-Commit-Position: refs/heads/master@{#424850}

Patch Set 1 #

Patch Set 2 : Rebased to correct commit #

Patch Set 3 : [scheduler] Throttle background frames with 1% CPU limit #

Total comments: 15

Patch Set 4 : Addressed comments from skyostil@ and alexclarke@ #

Patch Set 5 : Address skyostil@ comments. #

Total comments: 2

Patch Set 6 : Add comments to resources.grd for jochen@ #

Patch Set 7 : Updated histograms.xml to fix CustomLoginFlags failure #

Patch Set 8 : Updated histograms.xml to fix CustomLoginFlags failure #

Patch Set 9 : Fixed tests #

Total comments: 1

Patch Set 10 : Rebased & added test & added comment #

Patch Set 11 : Fixed SetQueueEnabled bug #

Patch Set 12 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -10 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +8 lines, -5 lines 0 comments Download
M content/child/runtime_features.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/common/content_features.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h View 1 2 3 4 5 6 7 8 11 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +80 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc View 1 2 3 4 3 chunks +28 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +36 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 79 (45 generated)
altimin
PTAL
4 years, 2 months ago (2016-09-27 15:56:20 UTC) #2
alex clarke (OOO till 29th)
https://codereview.chromium.org/2345483002/diff/40001/content/public/common/content_features.cc File content/public/common/content_features.cc (right): https://codereview.chromium.org/2345483002/diff/40001/content/public/common/content_features.cc#newcode39 content/public/common/content_features.cc:39: // for the background tab. Bug: crbug.com/639852. Maybe: See ...
4 years, 2 months ago (2016-09-27 16:32:10 UTC) #3
Sami
Looks great. https://codereview.chromium.org/2345483002/diff/40001/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right): https://codereview.chromium.org/2345483002/diff/40001/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in#newcode85 third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:85: ExpensiveBackgroundTimerThrottling status=experimental There's already a TimerThrottlingForBackgroundTabs feature. ...
4 years, 2 months ago (2016-09-27 17:11:56 UTC) #4
alex clarke (OOO till 29th)
https://codereview.chromium.org/2345483002/diff/40001/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h File third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h (right): https://codereview.chromium.org/2345483002/diff/40001/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h#newcode62 third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h:62: friend class WebFrameSchedulerImpl; On 2016/09/27 17:11:56, Sami wrote: > ...
4 years, 2 months ago (2016-09-27 17:16:23 UTC) #5
altimin
PTAL https://codereview.chromium.org/2345483002/diff/40001/content/public/common/content_features.cc File content/public/common/content_features.cc (right): https://codereview.chromium.org/2345483002/diff/40001/content/public/common/content_features.cc#newcode39 content/public/common/content_features.cc:39: // for the background tab. Bug: crbug.com/639852. On ...
4 years, 2 months ago (2016-09-27 17:38:23 UTC) #6
Sami
https://codereview.chromium.org/2345483002/diff/40001/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc (right): https://codereview.chromium.org/2345483002/diff/40001/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc#newcode59 third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc:59: TaskQueueThrottler::TimeBudgetPool* time_budget_pool = On 2016/09/27 17:38:23, altimin wrote: > ...
4 years, 2 months ago (2016-09-29 09:32:29 UTC) #7
altimin
PTAL https://codereview.chromium.org/2345483002/diff/40001/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc (right): https://codereview.chromium.org/2345483002/diff/40001/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc#newcode59 third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc:59: TaskQueueThrottler::TimeBudgetPool* time_budget_pool = On 2016/09/29 09:32:29, Sami wrote: ...
4 years, 2 months ago (2016-09-29 12:32:38 UTC) #8
altimin
PTAL
4 years, 2 months ago (2016-09-29 12:32:39 UTC) #9
Sami
Thanks, lgtm.
4 years, 2 months ago (2016-09-29 13:04:19 UTC) #10
altimin
+ jochen@ for all flag and features related changes
4 years, 2 months ago (2016-09-29 13:09:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345483002/80001
4 years, 2 months ago (2016-09-29 17:25:17 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/269756)
4 years, 2 months ago (2016-09-29 17:36:02 UTC) #16
jochen (gone - plz use gerrit)
https://codereview.chromium.org/2345483002/diff/80001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2345483002/diff/80001/chrome/app/generated_resources.grd#newcode15525 chrome/app/generated_resources.grd:15525: + <message name="IDS_FLAGS_EXPENSIVE_BACKGROUND_TIMER_THROTTLING_NAME"> please add a desc="" describing what ...
4 years, 2 months ago (2016-09-30 10:58:04 UTC) #17
jochen (gone - plz use gerrit)
btw, why do you need a content feature (as opposed to just a command line ...
4 years, 2 months ago (2016-09-30 10:58:25 UTC) #18
Sami
On 2016/09/30 10:58:25, jochen (slow) wrote: > btw, why do you need a content feature ...
4 years, 2 months ago (2016-09-30 11:04:47 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345483002/100001
4 years, 2 months ago (2016-09-30 11:37:28 UTC) #22
altimin
PTAL https://codereview.chromium.org/2345483002/diff/80001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2345483002/diff/80001/chrome/app/generated_resources.grd#newcode15525 chrome/app/generated_resources.grd:15525: + <message name="IDS_FLAGS_EXPENSIVE_BACKGROUND_TIMER_THROTTLING_NAME"> On 2016/09/30 10:58:03, jochen (slow) ...
4 years, 2 months ago (2016-09-30 11:37:36 UTC) #23
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-04 14:40:11 UTC) #29
altimin
+mpearson@ for histograms.xml change
4 years, 2 months ago (2016-10-04 15:31:08 UTC) #33
Mark P
histograms.xml lgtm
4 years, 2 months ago (2016-10-04 15:56:16 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345483002/140001
4 years, 2 months ago (2016-10-04 15:57:42 UTC) #42
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/309594)
4 years, 2 months ago (2016-10-04 17:19:22 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345483002/140001
4 years, 2 months ago (2016-10-04 17:44:14 UTC) #46
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/308198)
4 years, 2 months ago (2016-10-04 18:32:57 UTC) #48
alex clarke (OOO till 29th)
lgtm https://codereview.chromium.org/2345483002/diff/160001/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc (right): https://codereview.chromium.org/2345483002/diff/160001/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc#newcode48 third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc:48: background_time_budget_pool_->DisableThrottling(&lazy_now); Please add a comment explaining why this ...
4 years, 2 months ago (2016-10-05 12:01:54 UTC) #53
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345483002/180001
4 years, 2 months ago (2016-10-05 13:54:34 UTC) #60
commit-bot: I haz the power
Committed patchset #10 (id:180001)
4 years, 2 months ago (2016-10-05 15:53:28 UTC) #61
commit-bot: I haz the power
Patchset 10 (id:??) landed as https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da Cr-Commit-Position: refs/heads/master@{#423170}
4 years, 2 months ago (2016-10-05 15:55:37 UTC) #63
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345483002/200001
4 years, 2 months ago (2016-10-06 14:17:16 UTC) #67
commit-bot: I haz the power
Committed patchset #11 (id:200001)
4 years, 2 months ago (2016-10-06 18:45:00 UTC) #69
commit-bot: I haz the power
Patchset 11 (id:??) landed as https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22 Cr-Commit-Position: refs/heads/master@{#423604}
4 years, 2 months ago (2016-10-06 18:47:12 UTC) #71
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345483002/220001
4 years, 2 months ago (2016-10-12 19:00:24 UTC) #75
commit-bot: I haz the power
Committed patchset #12 (id:220001)
4 years, 2 months ago (2016-10-12 21:07:15 UTC) #77
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 21:10:55 UTC) #79
Message was sent while issue was closed.
Patchset 12 (id:??) landed as
https://crrev.com/1fca2bed4bacd6fb1dc7ffacd4c2d92d59ceae8f
Cr-Commit-Position: refs/heads/master@{#424850}

Powered by Google App Engine
This is Rietveld 408576698