Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc

Issue 2345483002: [scheduler] Throttle background frames with 1% CPU limit (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc b/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
index a1fb67218a33cc297a4a72eea5bc5a0f54116f0b..caf64ea7770d0299eda230d60491031616ffc245 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
@@ -723,5 +723,85 @@ TEST_F(TaskQueueThrottlerTest, TwoQueuesTimeBudgetThrottling) {
pool->Close();
}
+TEST_F(TaskQueueThrottlerTest, DisabledTimeBudgetDoesNotAffectThrottledQueues) {
+ std::vector<base::TimeTicks> run_times;
+ LazyNow lazy_now(clock_.get());
+
+ TaskQueueThrottler::TimeBudgetPool* pool =
+ task_queue_throttler_->CreateTimeBudgetPool("pool");
+ pool->SetTimeBudget(lazy_now.Now(), 0.1);
+ pool->DisableThrottling(&lazy_now);
+
+ pool->AddQueue(lazy_now.Now(), timer_queue_.get());
+
+ task_queue_throttler_->IncreaseThrottleRefCount(timer_queue_.get());
+
+ timer_queue_->PostDelayedTask(
+ FROM_HERE, base::Bind(&ExpensiveTestTask, &run_times, clock_.get()),
+ base::TimeDelta::FromMilliseconds(100));
+ timer_queue_->PostDelayedTask(
+ FROM_HERE, base::Bind(&ExpensiveTestTask, &run_times, clock_.get()),
+ base::TimeDelta::FromMilliseconds(100));
+
+ mock_task_runner_->RunUntilIdle();
+
+ EXPECT_THAT(
+ run_times,
+ ElementsAre(base::TimeTicks() + base::TimeDelta::FromMilliseconds(1000),
+ base::TimeTicks() + base::TimeDelta::FromMilliseconds(1250)));
+}
+
+TEST_F(TaskQueueThrottlerTest,
+ TimeBudgetThrottlingDoesNotAffectUnthrottledQueues) {
+ std::vector<base::TimeTicks> run_times;
+
+ TaskQueueThrottler::TimeBudgetPool* pool =
+ task_queue_throttler_->CreateTimeBudgetPool("pool");
+ pool->SetTimeBudget(base::TimeTicks(), 0.1);
+
+ LazyNow lazy_now(clock_.get());
+ pool->DisableThrottling(&lazy_now);
+
+ pool->AddQueue(clock_->NowTicks(), timer_queue_.get());
+
+ timer_queue_->PostDelayedTask(
+ FROM_HERE, base::Bind(&ExpensiveTestTask, &run_times, clock_.get()),
+ base::TimeDelta::FromMilliseconds(100));
+ timer_queue_->PostDelayedTask(
+ FROM_HERE, base::Bind(&ExpensiveTestTask, &run_times, clock_.get()),
+ base::TimeDelta::FromMilliseconds(100));
+
+ mock_task_runner_->RunUntilIdle();
+
+ EXPECT_THAT(
+ run_times,
+ ElementsAre(base::TimeTicks() + base::TimeDelta::FromMilliseconds(105),
+ base::TimeTicks() + base::TimeDelta::FromMilliseconds(355)));
+}
+
+TEST_F(TaskQueueThrottlerTest,
+ TimeBudgetThrottlingDoesNotConflictWithSetQueueEnabled) {
+ timer_queue_->SetQueueEnabled(false);
+
+ std::vector<base::TimeTicks> run_times;
+
+ TaskQueueThrottler::TimeBudgetPool* pool =
+ task_queue_throttler_->CreateTimeBudgetPool("pool");
+ pool->SetTimeBudget(clock_->NowTicks(), 0.1);
+
+ pool->AddQueue(clock_->NowTicks(), timer_queue_.get());
+
+ task_queue_throttler_->SetQueueEnabled(timer_queue_.get(), true);
+
+ timer_queue_->PostDelayedTask(
+ FROM_HERE, base::Bind(&ExpensiveTestTask, &run_times, clock_.get()),
+ base::TimeDelta::FromMilliseconds(100));
+
+ mock_task_runner_->RunUntilIdle();
+
+ EXPECT_THAT(run_times, ElementsAre(base::TimeTicks() +
+ base::TimeDelta::FromMilliseconds(105)));
+}
+
} // namespace scheduler
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698