Change ScopedTempDir::path() to GetPath() in chrome/browser/chromeos/file_manager

Change ScopedTempDir::path() to GetPath() in chrome/browser/chromeos/file_manager

This CL also changes TestVolume::CreateRootDirectory to handle that GetPath()
(unlike path()) cannot be called before initialising the ScopedTempDir. Because
CreateRootDirectory apparently can be called multiple times from
FakeTestVolume, it needs to handle that and not initialise the directory twice.
On the other hand, the directory cannot be initialised from anywhere else, so
this CL made this clear by adding a Boolean member root_initialized_ which is
updated and checked by CreateRootDirectory. Using the Boolean member, unlike
just handling the fact that the directory has been already initialised (this
information is still possible to retrieve via Take()+Set()), makes it clearer
that the assumption is the directory only being initialised where also
root_initialized_ is set.

R=achuith@chromium.org
BUG=640599
Committed: https://crrev.com/eca5e5cf8a6d74f021953d804cabd8c4dd9c8b9b
Cr-Commit-Position: refs/heads/master@{#418797}

[vabr (Chromium), 2016-09-14 10:58:05]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 10:58:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-09-14 10:59:22]

Description was changed from

==========
Change ScopedTempDir::path() to GetPath() in
chrome/browser/chromeos/file_manager

This CL also changes TestVolume::CreateRootDirectory to handle that GetPath()
(unlike path()) cannot be called before initialising the ScopedTempDir. Because
CreateRootDirectory apparently can be called multiple times from FakeTestVolume,
it needs to handle that and not initialise the directory twice. On the other
hand, the directory cannot be initialised from anywhere else, so this CL made
this clear by adding a Boolean member root_initialized_ which is updated and
checked by CreateRootDirectory. Using the Boolean member, unlike just handling
the fact that the directory has been already initialised (this information is
still possible to retrieve via Take()+Set()), makes it clearer that the
assumption is the directory only being initialised where also root_initialized_
is set.

R=achuith@chromium.org
BUG=640599
==========

to

==========
Change ScopedTempDir::path() to GetPath() in
chrome/browser/chromeos/file_manager

This CL also changes TestVolume::CreateRootDirectory to handle that GetPath()
(unlike path()) cannot be called before initialising the ScopedTempDir. Because
CreateRootDirectory apparently can be called multiple times from
FakeTestVolume, it needs to handle that and not initialise the directory twice.
On the other hand, the directory cannot be initialised from anywhere else, so
this CL made this clear by adding a Boolean member root_initialized_ which is
updated and checked by CreateRootDirectory. Using the Boolean member, unlike
just handling the fact that the directory has been already initialised (this
information is still possible to retrieve via Take()+Set()), makes it clearer
that the assumption is the directory only being initialised where also
root_initialized_ is set.

R=achuith@chromium.org
BUG=640599
==========

[commit-bot: I haz the power, 2016-09-14 11:37:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 11:37:18]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-09-14 12:08:05]

Hi achuithb@,

I addressed your comments from the original
https://codereview.chromium.org/2318023002/. I believe my changes are in the
spirit of what you approved, but will hold off with landing this until tomorrow,
in case you have any concerns. After that I'll TBR you, and of course will be
happy to do any follow-up CLs if requested.

Cheers,
Vaclav

[achuithb, 2016-09-14 20:40:47]

lgtm, thanks!

[vabr (Chromium), 2016-09-15 07:24:32]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-09-15 07:24:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 07:30:20]

Description was changed from

==========
Change ScopedTempDir::path() to GetPath() in
chrome/browser/chromeos/file_manager

This CL also changes TestVolume::CreateRootDirectory to handle that GetPath()
(unlike path()) cannot be called before initialising the ScopedTempDir. Because
CreateRootDirectory apparently can be called multiple times from
FakeTestVolume, it needs to handle that and not initialise the directory twice.
On the other hand, the directory cannot be initialised from anywhere else, so
this CL made this clear by adding a Boolean member root_initialized_ which is
updated and checked by CreateRootDirectory. Using the Boolean member, unlike
just handling the fact that the directory has been already initialised (this
information is still possible to retrieve via Take()+Set()), makes it clearer
that the assumption is the directory only being initialised where also
root_initialized_ is set.

R=achuith@chromium.org
BUG=640599
==========

to

==========
Change ScopedTempDir::path() to GetPath() in
chrome/browser/chromeos/file_manager

This CL also changes TestVolume::CreateRootDirectory to handle that GetPath()
(unlike path()) cannot be called before initialising the ScopedTempDir. Because
CreateRootDirectory apparently can be called multiple times from
FakeTestVolume, it needs to handle that and not initialise the directory twice.
On the other hand, the directory cannot be initialised from anywhere else, so
this CL made this clear by adding a Boolean member root_initialized_ which is
updated and checked by CreateRootDirectory. Using the Boolean member, unlike
just handling the fact that the directory has been already initialised (this
information is still possible to retrieve via Take()+Set()), makes it clearer
that the assumption is the directory only being initialised where also
root_initialized_ is set.

R=achuith@chromium.org
BUG=640599
==========

[commit-bot: I haz the power, 2016-09-15 07:30:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-15 07:31:41]

Description was changed from

==========
Change ScopedTempDir::path() to GetPath() in
chrome/browser/chromeos/file_manager

This CL also changes TestVolume::CreateRootDirectory to handle that GetPath()
(unlike path()) cannot be called before initialising the ScopedTempDir. Because
CreateRootDirectory apparently can be called multiple times from
FakeTestVolume, it needs to handle that and not initialise the directory twice.
On the other hand, the directory cannot be initialised from anywhere else, so
this CL made this clear by adding a Boolean member root_initialized_ which is
updated and checked by CreateRootDirectory. Using the Boolean member, unlike
just handling the fact that the directory has been already initialised (this
information is still possible to retrieve via Take()+Set()), makes it clearer
that the assumption is the directory only being initialised where also
root_initialized_ is set.

R=achuith@chromium.org
BUG=640599
==========

to

==========
Change ScopedTempDir::path() to GetPath() in
chrome/browser/chromeos/file_manager

This CL also changes TestVolume::CreateRootDirectory to handle that GetPath()
(unlike path()) cannot be called before initialising the ScopedTempDir. Because
CreateRootDirectory apparently can be called multiple times from
FakeTestVolume, it needs to handle that and not initialise the directory twice.
On the other hand, the directory cannot be initialised from anywhere else, so
this CL made this clear by adding a Boolean member root_initialized_ which is
updated and checked by CreateRootDirectory. Using the Boolean member, unlike
just handling the fact that the directory has been already initialised (this
information is still possible to retrieve via Take()+Set()), makes it clearer
that the assumption is the directory only being initialised where also
root_initialized_ is set.

R=achuith@chromium.org
BUG=640599

Committed: https://crrev.com/eca5e5cf8a6d74f021953d804cabd8c4dd9c8b9b
Cr-Commit-Position: refs/heads/master@{#418797}
==========

[commit-bot: I haz the power, 2016-09-15 07:31:44]

Patchset 1 (id:??) landed as
https://crrev.com/eca5e5cf8a6d74f021953d804cabd8c4dd9c8b9b
Cr-Commit-Position: refs/heads/master@{#418797}