Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2338793004: Change ScopedTempDir::path() to GetPath() in external_filesystem_apitest.cc (Closed)

Created:
4 years, 3 months ago by vabr (Chromium)
Modified:
4 years, 3 months ago
Reviewers:
achuithb
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change ScopedTempDir::path() to GetPath() in external_filesystem_apitest.cc This CL also fixes what seems like a bug, where the original code used the scoped temp dir path before initialization, which meant files were put in the directory "" (presumably the current working directory). TBR-ing achuith@, who approved this in https://codereview.chromium.org/2318023002/ and suggested splitting off into a separate CL. TBR=achuith@chromium.org BUG=640599 Committed: https://crrev.com/f7079a223322703f4165d246b99a098d77df4928 Cr-Commit-Position: refs/heads/master@{#418535}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc View 6 chunks +10 lines, -12 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
vabr (Chromium)
TBR-ing achuith@, who approved this in https://codereview.chromium.org/2318023002/ and suggested splitting off into a separate CL.
4 years, 3 months ago (2016-09-14 11:18:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338793004/1
4 years, 3 months ago (2016-09-14 11:18:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 11:23:00 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f7079a223322703f4165d246b99a098d77df4928 Cr-Commit-Position: refs/heads/master@{#418535}
4 years, 3 months ago (2016-09-14 11:24:29 UTC) #9
achuithb
4 years, 3 months ago (2016-09-14 20:39:15 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698