Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 234533002: Remove a bunch of TOOLKIT_GTK in content/ and gpu/, as well as NPAPI plugins on linux (Closed)

Created:
6 years, 8 months ago by piman
Modified:
6 years, 8 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, nasko+codewatch_chromium.org, sievers+watch_chromium.org, yukishiino+watch_chromium.org, dmazzoni+watch_chromium.org, miu+watch_chromium.org, aboxhall+watch_chromium.org, jam, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, creis+watch_chromium.org, penghuang+watch_chromium.org, yuzo+watch_chromium.org, piman+watch_chromium.org, jochen+watch_chromium.org, plundblad+watch_chromium.org, dtseng+watch_chromium.org, danakj+watch_chromium.org, James Su, jln+watch_chromium.org
Visibility:
Public.

Description

Remove a bunch of TOOLKIT_GTK in content/ and gpu/, as well as NPAPI plugins on linux BUG=297026 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263288

Patch Set 1 #

Patch Set 2 : rebase, skip changing browser_main_loop.cc because of presubmit issues, will follow up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -848 lines) Patch
M chrome/chrome_tests.gypi View 1 1 chunk +6 lines, -1 line 0 comments Download
M content/app/content_main_runner.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M content/browser/gpu/test_support_gpu.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_sandbox_host_linux.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M content/browser/webui/web_ui_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/npapi/plugin_host.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M content/child/npapi/webplugin_delegate_impl.h View 3 chunks +0 lines, -33 lines 0 comments Download
M content/common/cursors/webcursor_unittest.cc View 3 chunks +0 lines, -21 lines 0 comments Download
M content/common/gpu/client/gl_helper_unittest.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M content/common/plugin_process_messages.h View 1 chunk +0 lines, -10 lines 0 comments Download
M content/common/sandbox_linux/bpf_ppapi_policy_linux.cc View 2 chunks +0 lines, -23 lines 0 comments Download
M content/common/sandbox_linux/bpf_renderer_policy_linux.cc View 2 chunks +0 lines, -23 lines 0 comments Download
M content/common/swapped_out_messages.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -14 lines 0 comments Download
M content/content_browsertests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_plugin.gypi View 3 chunks +1 line, -12 lines 0 comments Download
M content/content_shell.gypi View 2 chunks +2 lines, -3 lines 0 comments Download
M content/content_tests.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/plugin/plugin_main.cc View 2 chunks +1 line, -10 lines 0 comments Download
D content/plugin/plugin_main_linux.cc View 1 chunk +0 lines, -74 lines 0 comments Download
M content/plugin/plugin_thread.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/plugin/webplugin_proxy.h View 4 chunks +0 lines, -30 lines 0 comments Download
M content/plugin/webplugin_proxy.cc View 6 chunks +0 lines, -106 lines 0 comments Download
M content/public/browser/native_web_keyboard_event.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/render_widget_host.h View 2 chunks +2 lines, -8 lines 0 comments Download
M content/public/common/common_param_traits.h View 1 chunk +0 lines, -18 lines 0 comments Download
M content/public/test/mock_render_process_host.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 2 chunks +1 line, -5 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 2 chunks +1 line, -13 lines 0 comments Download
M content/renderer/pepper/ppb_image_data_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/renderer/render_process_impl.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/webscrollbarbehavior_impl_gtkoraura.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M content/shell/browser/shell.h View 2 chunks +1 line, -31 lines 0 comments Download
M content/shell/browser/shell_javascript_dialog_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_javascript_dialog_manager.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/shell/browser/shell_login_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_resource_dispatcher_host_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/webkit_test_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/event_sender.cc View 4 chunks +2 lines, -10 lines 0 comments Download
M content/shell/renderer/test_runner/key_code_mapping.h View 1 chunk +0 lines, -3 lines 0 comments Download
D content/shell/renderer/test_runner/key_code_mapping.cc View 1 chunk +0 lines, -221 lines 0 comments Download
M content/test/plugin/plugin_javascript_open_popup.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M content/test/plugin/plugin_windowless_test.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/test/test_render_view_host.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M gpu/command_buffer/tests/gl_tests_main.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M gpu/gles2_conform_support/native/main.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
piman
erg: please review jschuh: IPC security review: content/common/plugin_process_messages.h content/common/view_messages.h content/public/common/common_param_traits.h
6 years, 8 months ago (2014-04-11 01:26:04 UTC) #1
jln (very slow on Chromium)
IPC security lgtm (also very happy to see this go away in the sandbox)
6 years, 8 months ago (2014-04-11 01:29:31 UTC) #2
Elliot Glaysher
lgtm (The next couple of days are going to be interesting. I suspect people are ...
6 years, 8 months ago (2014-04-11 03:25:37 UTC) #3
piman
The CQ bit was checked by piman@chromium.org
6 years, 8 months ago (2014-04-11 03:36:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/234533002/1
6 years, 8 months ago (2014-04-11 03:36:45 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 05:12:43 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=60877
6 years, 8 months ago (2014-04-11 05:12:43 UTC) #7
piman
The CQ bit was checked by piman@chromium.org
6 years, 8 months ago (2014-04-11 07:50:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/234533002/20001
6 years, 8 months ago (2014-04-11 07:50:27 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 08:38:48 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-11 08:38:48 UTC) #11
piman
The CQ bit was checked by piman@chromium.org
6 years, 8 months ago (2014-04-11 16:50:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/234533002/20001
6 years, 8 months ago (2014-04-11 16:51:33 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-11 18:26:04 UTC) #14
Message was sent while issue was closed. 
Change committed as 263288

Powered by Google App Engine
This is Rietveld 408576698