content/shell/browser/shell_login_dialog.cc - Issue 234533002: Remove a bunch of TOOLKIT_GTK in content/ and gpu/, as well as NPAPI plugins on linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_login_dialog.cc

Issue 234533002: Remove a bunch of TOOLKIT_GTK in content/ and gpu/, as well as NPAPI plugins on linux (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase, skip changing browser_main_loop.cc because of presubmit issues, will follow up Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/shell_javascript_dialog_manager.cc ('k') | content/shell/browser/shell_resource_dispatcher_host_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/shell_login_dialog.cc

diff --git a/content/shell/browser/shell_login_dialog.cc b/content/shell/browser/shell_login_dialog.cc

index b531b659a963b418ee390c53e93e7af7ecb66cc4..fe7da40b879e9e4a7ab61bf3f934bec394e1fbfc 100644

--- a/content/shell/browser/shell_login_dialog.cc

+++ b/content/shell/browser/shell_login_dialog.cc

@@ -59,7 +59,7 @@ ShellLoginDialog::~ShellLoginDialog() {

// referenced/dereferenced.

}

-#if !defined(OS_MACOSX) && !defined(TOOLKIT_GTK)

+#if !defined(OS_MACOSX)

// Bogus implementations for linking. They are never called because

// ResourceDispatcherHostDelegate::CreateLoginDelegate returns NULL.

// TODO: implement ShellLoginDialog for other platforms, drop this #if