Issue 23453004: Update SkLumaMaskXfermode partial coverage handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23453004: Update SkLumaMaskXfermode partial coverage handling. (Closed)

Created:
7 years, 3 months ago by f(malita)

Modified:
7 years, 3 months ago

Reviewers:
bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Update SkLumaMaskXfermode partial coverage handling. Use lerp-to-dst instead of straight coverage scaling to align the behavior with the other transfer modes. R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=10927

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/effects/SkLumaXfermode.cpp	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

f(malita)

On 2013/08/26 20:56:49, Florin Malita wrote: Patch set 1 was actually incorrect, we should always ...

7 years, 3 months ago (2013-08-26 21:13:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/23453004/6001

7 years, 3 months ago (2013-08-26 21:17:03 UTC) #4

f(malita)

7 years, 3 months ago (2013-08-26 21:47:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r10927 (presubmit successful).