Remove content::RequestInfo

Remove content::RequestInfo

This class is used only for passing bunch of parameters to the
ResourceDispatcher from the WebURLLoaderImpl. Inside ResourceDispatcher,
almost all of the members are just copied to a ResourceRequest created
in it and converted into an IPC message. It's useless and is bothering
developers with extra click when exploring and coding of trivial lines.
Let's remove it.

Comments in request_info.h are copied to resource_request.h and
resource_dispatcher.h if needed.

ResourceRequest creation logic in unit tests are adjusted so that
variables for which the default value of RequestInfo is different from
one of ResourceRequest are set to one of RequestInfo as before.

Bonus: Typo fix visiblity -> visibility

R=jam@chromium.org,tsepez@chromium.org
BUG=none

Committed: https://crrev.com/3191d5fe4e3c5778b72c7e3ff5a9ae37783d849d
Cr-Commit-Position: refs/heads/master@{#419997}

[tyoshino (SeeGerritForStatus), 2016-09-16 13:38:31]

Patchset #1 (id:1) has been deleted

[tyoshino (SeeGerritForStatus), 2016-09-16 13:38:38]

Patchset #1 (id:20001) has been deleted

[tyoshino (SeeGerritForStatus), 2016-09-16 13:39:41]

Patchset #1 (id:40001) has been deleted

[tyoshino (SeeGerritForStatus), 2016-09-16 14:10:51]

Description was changed from

==========
Remove content::RequestInfo

This class is used only for passing bunch of parameters to the
ResourceDispatcher from the WebURLLoaderImpl. Inside ResourceDispatcher,
almost all of members are just copied to a ResourceRequest created in it
and converted into an IPC message. It's useless and adding extra click
when we're reading code. Just remove it.

BUG=none
==========

to

==========
Remove content::RequestInfo

This class is used only for passing bunch of parameters to the
ResourceDispatcher from the WebURLLoaderImpl. Inside ResourceDispatcher,
almost all of members are just copied to a ResourceRequest created in it
and converted into an IPC message. It's useless and adding extra click
when we're reading code. Just remove it.

Bonus: Typo fix visiblity -> visibility

BUG=none
==========

[tyoshino (SeeGerritForStatus), 2016-09-16 14:26:23]

Patchset #1 (id:60001) has been deleted

[tyoshino (SeeGerritForStatus), 2016-09-16 14:26:31]

Patchset #1 (id:80001) has been deleted

[tyoshino (SeeGerritForStatus), 2016-09-16 14:26:37]

Patchset #1 (id:100001) has been deleted

[tyoshino (SeeGerritForStatus), 2016-09-16 14:31:09]

Description was changed from

==========
Remove content::RequestInfo

This class is used only for passing bunch of parameters to the
ResourceDispatcher from the WebURLLoaderImpl. Inside ResourceDispatcher,
almost all of members are just copied to a ResourceRequest created in it
and converted into an IPC message. It's useless and adding extra click
when we're reading code. Just remove it.

Bonus: Typo fix visiblity -> visibility

BUG=none
==========

to

==========
Remove content::RequestInfo

This class is used only for passing bunch of parameters to the
ResourceDispatcher from the WebURLLoaderImpl. Inside ResourceDispatcher,
almost all of members are just copied to a ResourceRequest created in it
and converted into an IPC message. It's useless and adding extra click
when we're reading code. Just remove it.

Comments in request_info.h are copied to resource_request.h and
resource_dispatcher.h if needed.

ResourceRequest creation logic in unit tests are adjusted so that
variables for which the default value of RequestInfo is different from
one of ResourceRequest are set to one of RequestInfo as before.

Bonus: Typo fix visiblity -> visibility

BUG=none
==========

[tyoshino (SeeGerritForStatus), 2016-09-16 14:45:11]

Patchset #1 (id:120001) has been deleted

[tyoshino (SeeGerritForStatus), 2016-09-16 14:49:43]

Description was changed from

==========
Remove content::RequestInfo

This class is used only for passing bunch of parameters to the
ResourceDispatcher from the WebURLLoaderImpl. Inside ResourceDispatcher,
almost all of members are just copied to a ResourceRequest created in it
and converted into an IPC message. It's useless and adding extra click
when we're reading code. Just remove it.

Comments in request_info.h are copied to resource_request.h and
resource_dispatcher.h if needed.

ResourceRequest creation logic in unit tests are adjusted so that
variables for which the default value of RequestInfo is different from
one of ResourceRequest are set to one of RequestInfo as before.

Bonus: Typo fix visiblity -> visibility

BUG=none
==========

to

==========
Remove content::RequestInfo

This class is used only for passing bunch of parameters to the
ResourceDispatcher from the WebURLLoaderImpl. Inside ResourceDispatcher,
almost all of the members are just copied to a ResourceRequest created
in it and converted into an IPC message. It's useless and is bothering
developers with extra click when exploring and coding of trivial lines.
Let's remove it.

Comments in request_info.h are copied to resource_request.h and
resource_dispatcher.h if needed.

ResourceRequest creation logic in unit tests are adjusted so that
variables for which the default value of RequestInfo is different from
one of ResourceRequest are set to one of RequestInfo as before.

Bonus: Typo fix visiblity -> visibility

BUG=none
==========

[tyoshino (SeeGerritForStatus), 2016-09-16 14:49:54]

Description was changed from

==========
Remove content::RequestInfo

This class is used only for passing bunch of parameters to the
ResourceDispatcher from the WebURLLoaderImpl. Inside ResourceDispatcher,
almost all of the members are just copied to a ResourceRequest created
in it and converted into an IPC message. It's useless and is bothering
developers with extra click when exploring and coding of trivial lines.
Let's remove it.

Comments in request_info.h are copied to resource_request.h and
resource_dispatcher.h if needed.

ResourceRequest creation logic in unit tests are adjusted so that
variables for which the default value of RequestInfo is different from
one of ResourceRequest are set to one of RequestInfo as before.

Bonus: Typo fix visiblity -> visibility

BUG=none
==========

to

==========
Remove content::RequestInfo

This class is used only for passing bunch of parameters to the
ResourceDispatcher from the WebURLLoaderImpl. Inside ResourceDispatcher,
almost all of the members are just copied to a ResourceRequest created
in it and converted into an IPC message. It's useless and is bothering
developers with extra click when exploring and coding of trivial lines.
Let's remove it.

Comments in request_info.h are copied to resource_request.h and
resource_dispatcher.h if needed.

ResourceRequest creation logic in unit tests are adjusted so that
variables for which the default value of RequestInfo is different from
one of ResourceRequest are set to one of RequestInfo as before.

Bonus: Typo fix visiblity -> visibility

BUG=none
==========

[tyoshino (SeeGerritForStatus), 2016-09-16 14:49:54]

tyoshino@chromium.org changed reviewers:
+ jam@chromium.org

[tyoshino (SeeGerritForStatus), 2016-09-16 14:50:10]

The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 14:50:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tyoshino (SeeGerritForStatus), 2016-09-16 14:50:51]

Hi John,

I'm going home. Please take a look only when the dry-run bots are green when you
see this.

Thanks

[commit-bot: I haz the power, 2016-09-16 16:00:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 16:00:38]

Dry run: This issue passed the CQ dry run.

[jam, 2016-09-16 16:39:54]

lgtm 👍

[tyoshino (SeeGerritForStatus), 2016-09-17 01:13:17]

Description was changed from

==========
Remove content::RequestInfo

This class is used only for passing bunch of parameters to the
ResourceDispatcher from the WebURLLoaderImpl. Inside ResourceDispatcher,
almost all of the members are just copied to a ResourceRequest created
in it and converted into an IPC message. It's useless and is bothering
developers with extra click when exploring and coding of trivial lines.
Let's remove it.

Comments in request_info.h are copied to resource_request.h and
resource_dispatcher.h if needed.

ResourceRequest creation logic in unit tests are adjusted so that
variables for which the default value of RequestInfo is different from
one of ResourceRequest are set to one of RequestInfo as before.

Bonus: Typo fix visiblity -> visibility

BUG=none
==========

to

==========
Remove content::RequestInfo

This class is used only for passing bunch of parameters to the
ResourceDispatcher from the WebURLLoaderImpl. Inside ResourceDispatcher,
almost all of the members are just copied to a ResourceRequest created
in it and converted into an IPC message. It's useless and is bothering
developers with extra click when exploring and coding of trivial lines.
Let's remove it.

Comments in request_info.h are copied to resource_request.h and
resource_dispatcher.h if needed.

ResourceRequest creation logic in unit tests are adjusted so that
variables for which the default value of RequestInfo is different from
one of ResourceRequest are set to one of RequestInfo as before.

Bonus: Typo fix visiblity -> visibility

R=jam@chromium.org
BUG=none
==========

[tyoshino (SeeGerritForStatus), 2016-09-17 01:13:25]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2016-09-17 01:13:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 01:22:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 01:22:47]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tyoshino (SeeGerritForStatus), 2016-09-17 11:31:44]

tyoshino@chromium.org changed reviewers:
+ mkwst@chromium.org

[tyoshino (SeeGerritForStatus), 2016-09-17 11:31:45]

+mkwst

Hi Mike, could you please review the IPC definition file?

[tyoshino (SeeGerritForStatus), 2016-09-20 03:51:39]

tyoshino@chromium.org changed reviewers:
+ tsepez@chromium.org

[tyoshino (SeeGerritForStatus), 2016-09-20 03:52:01]

On 2016/09/17 11:31:45, tyoshino wrote:
> +mkwst
> 
> Hi Mike, could you please review the IPC definition file?

-mkwst
+tsepez

As Mike is OOO this week.

[tyoshino (SeeGerritForStatus), 2016-09-20 03:52:14]

tyoshino@chromium.org changed reviewers:
- mkwst@chromium.org

[Tom Sepez, 2016-09-20 16:37:16]

messages LGTM.

[tyoshino (SeeGerritForStatus), 2016-09-21 05:10:01]

Description was changed from

==========
Remove content::RequestInfo

This class is used only for passing bunch of parameters to the
ResourceDispatcher from the WebURLLoaderImpl. Inside ResourceDispatcher,
almost all of the members are just copied to a ResourceRequest created
in it and converted into an IPC message. It's useless and is bothering
developers with extra click when exploring and coding of trivial lines.
Let's remove it.

Comments in request_info.h are copied to resource_request.h and
resource_dispatcher.h if needed.

ResourceRequest creation logic in unit tests are adjusted so that
variables for which the default value of RequestInfo is different from
one of ResourceRequest are set to one of RequestInfo as before.

Bonus: Typo fix visiblity -> visibility

R=jam@chromium.org
BUG=none
==========

to

==========
Remove content::RequestInfo

This class is used only for passing bunch of parameters to the
ResourceDispatcher from the WebURLLoaderImpl. Inside ResourceDispatcher,
almost all of the members are just copied to a ResourceRequest created
in it and converted into an IPC message. It's useless and is bothering
developers with extra click when exploring and coding of trivial lines.
Let's remove it.

Comments in request_info.h are copied to resource_request.h and
resource_dispatcher.h if needed.

ResourceRequest creation logic in unit tests are adjusted so that
variables for which the default value of RequestInfo is different from
one of ResourceRequest are set to one of RequestInfo as before.

Bonus: Typo fix visiblity -> visibility

R=jam@chromium.org,tsepez@chromium.org
BUG=none
==========

[tyoshino (SeeGerritForStatus), 2016-09-21 05:17:29]

The CQ bit was checked by tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2016-09-21 05:17:30]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2345253002/#ps160001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-21 05:17:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 06:19:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 06:19:58]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tyoshino (SeeGerritForStatus), 2016-09-21 06:37:32]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2016-09-21 06:38:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 07:28:23]

Description was changed from

==========
Remove content::RequestInfo

This class is used only for passing bunch of parameters to the
ResourceDispatcher from the WebURLLoaderImpl. Inside ResourceDispatcher,
almost all of the members are just copied to a ResourceRequest created
in it and converted into an IPC message. It's useless and is bothering
developers with extra click when exploring and coding of trivial lines.
Let's remove it.

Comments in request_info.h are copied to resource_request.h and
resource_dispatcher.h if needed.

ResourceRequest creation logic in unit tests are adjusted so that
variables for which the default value of RequestInfo is different from
one of ResourceRequest are set to one of RequestInfo as before.

Bonus: Typo fix visiblity -> visibility

R=jam@chromium.org,tsepez@chromium.org
BUG=none
==========

to

==========
Remove content::RequestInfo

This class is used only for passing bunch of parameters to the
ResourceDispatcher from the WebURLLoaderImpl. Inside ResourceDispatcher,
almost all of the members are just copied to a ResourceRequest created
in it and converted into an IPC message. It's useless and is bothering
developers with extra click when exploring and coding of trivial lines.
Let's remove it.

Comments in request_info.h are copied to resource_request.h and
resource_dispatcher.h if needed.

ResourceRequest creation logic in unit tests are adjusted so that
variables for which the default value of RequestInfo is different from
one of ResourceRequest are set to one of RequestInfo as before.

Bonus: Typo fix visiblity -> visibility

R=jam@chromium.org,tsepez@chromium.org
BUG=none
==========

[commit-bot: I haz the power, 2016-09-21 07:28:25]

Committed patchset #2 (id:160001)

[commit-bot: I haz the power, 2016-09-21 07:32:02]

Description was changed from

==========
Remove content::RequestInfo

This class is used only for passing bunch of parameters to the
ResourceDispatcher from the WebURLLoaderImpl. Inside ResourceDispatcher,
almost all of the members are just copied to a ResourceRequest created
in it and converted into an IPC message. It's useless and is bothering
developers with extra click when exploring and coding of trivial lines.
Let's remove it.

Comments in request_info.h are copied to resource_request.h and
resource_dispatcher.h if needed.

ResourceRequest creation logic in unit tests are adjusted so that
variables for which the default value of RequestInfo is different from
one of ResourceRequest are set to one of RequestInfo as before.

Bonus: Typo fix visiblity -> visibility

R=jam@chromium.org,tsepez@chromium.org
BUG=none
==========

to

==========
Remove content::RequestInfo

This class is used only for passing bunch of parameters to the
ResourceDispatcher from the WebURLLoaderImpl. Inside ResourceDispatcher,
almost all of the members are just copied to a ResourceRequest created
in it and converted into an IPC message. It's useless and is bothering
developers with extra click when exploring and coding of trivial lines.
Let's remove it.

Comments in request_info.h are copied to resource_request.h and
resource_dispatcher.h if needed.

ResourceRequest creation logic in unit tests are adjusted so that
variables for which the default value of RequestInfo is different from
one of ResourceRequest are set to one of RequestInfo as before.

Bonus: Typo fix visiblity -> visibility

R=jam@chromium.org,tsepez@chromium.org
BUG=none

Committed: https://crrev.com/3191d5fe4e3c5778b72c7e3ff5a9ae37783d849d
Cr-Commit-Position: refs/heads/master@{#419997}
==========

[commit-bot: I haz the power, 2016-09-21 07:32:03]

Patchset 2 (id:??) landed as
https://crrev.com/3191d5fe4e3c5778b72c7e3ff5a9ae37783d849d
Cr-Commit-Position: refs/heads/master@{#419997}