Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: content/child/resource_dispatcher.h

Issue 2345253002: Remove content::RequestInfo (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/request_info.cc ('k') | content/child/resource_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/resource_dispatcher.h
diff --git a/content/child/resource_dispatcher.h b/content/child/resource_dispatcher.h
index 5ef632fdf4b9f2499e1670359babd05ffbdedfd3..7f4731293cf9e390a6c499f6070a4473e80cf2f8 100644
--- a/content/child/resource_dispatcher.h
+++ b/content/child/resource_dispatcher.h
@@ -72,8 +72,11 @@ class CONTENT_EXPORT ResourceDispatcher : public IPC::Listener {
// use this if you really need it! There is also no way for the caller to
// interrupt this method. Errors are reported via the status field of the
// response parameter.
- virtual void StartSync(const RequestInfo& request_info,
- ResourceRequestBodyImpl* request_body,
+ //
+ // |routing_id| is used to associated the bridge with a frame's network
+ // context.
+ virtual void StartSync(std::unique_ptr<ResourceRequest> request,
+ int routing_id,
SyncLoadResponse* response,
blink::WebURLRequest::LoadingIPCType ipc_type,
mojom::URLLoaderFactory* url_loader_factory);
@@ -82,11 +85,20 @@ class CONTENT_EXPORT ResourceDispatcher : public IPC::Listener {
// the peer's methods will be called asynchronously to report various events.
// Returns the request id. |url_loader_factory| must be non-null if and only
// if |ipc_type| is LoadingIPCType::Mojo.
- virtual int StartAsync(const RequestInfo& request_info,
- ResourceRequestBodyImpl* request_body,
- std::unique_ptr<RequestPeer> peer,
- blink::WebURLRequest::LoadingIPCType ipc_type,
- mojom::URLLoaderFactory* url_loader_factory);
+ //
+ // |routing_id| is used to associated the bridge with a frame's network
+ // context.
+ //
+ // You can pass an optional argument |loading_task_runner| to specify task
+ // queue to execute loading tasks on.
+ virtual int StartAsync(
+ std::unique_ptr<ResourceRequest> request,
+ int routing_id,
+ scoped_refptr<base::SingleThreadTaskRunner> loading_task_runner,
+ const GURL& frame_origin,
+ std::unique_ptr<RequestPeer> peer,
+ blink::WebURLRequest::LoadingIPCType ipc_type,
+ mojom::URLLoaderFactory* url_loader_factory);
// Removes a request from the |pending_requests_| list, returning true if the
// request was found and removed.
« no previous file with comments | « content/child/request_info.cc ('k') | content/child/resource_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698