Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 2345223002: Slim includes in CSSValue.h (Closed)

Created:
4 years, 3 months ago by fs
Modified:
4 years, 3 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, jfernandez, Manuel Rego, rwlbuis, svillar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Slim includes in CSSValue.h This drops includes from CSSValue.h that are not directly used by it. Downstream dependents are fixed up as needed. Also strip some includes from StyleImage.h and other places that includes CSSValue.h while there. Committed: https://crrev.com/e1cc00be6c15325c03c7699bb0f896d3e9b3bf43 Cr-Commit-Position: refs/heads/master@{#419384}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M third_party/WebKit/Source/core/css/CSSCustomIdentValue.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFamilyValue.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSGridLineNamesValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSGridLineNamesValue.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSStringValue.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSUnicodeRangeValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSValue.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueList.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.h View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleImage.h View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleImage.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
fs
4 years, 3 months ago (2016-09-16 14:32:21 UTC) #6
Timothy Loh
lgtm
4 years, 3 months ago (2016-09-16 16:15:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345223002/1
4 years, 3 months ago (2016-09-17 16:33:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-17 20:19:04 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e1cc00be6c15325c03c7699bb0f896d3e9b3bf43 Cr-Commit-Position: refs/heads/master@{#419384}
4 years, 3 months ago (2016-09-17 20:22:30 UTC) #12
findit-for-me
FYI: Findit identified this CL at revision 419384 as the culprit for failures in the ...
4 years, 3 months ago (2016-09-17 20:58:49 UTC) #13
Avi (use Gerrit)
On 2016/09/17 20:58:49, findit-for-me wrote: > FYI: Findit identified this CL at revision 419384 as ...
4 years, 3 months ago (2016-09-17 21:03:04 UTC) #14
fs
4 years, 3 months ago (2016-09-17 21:04:43 UTC) #15
Message was sent while issue was closed.
On 2016/09/17 at 21:03:04, avi wrote:
> On 2016/09/17 20:58:49, findit-for-me wrote:
> > FYI: Findit identified this CL at revision 419384 as the culprit for
> > failures in the build cycles as shown on:
> >
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> 
> FindIt is incorrect. It is the similar CL
https://codereview.chromium.org/2345893004 that caused the failures, and I
reverted it.

I think they may have been in on it together ;-)

Powered by Google App Engine
This is Rietveld 408576698