Evacuate ComputedStyle references from the CSS*Value hierarchy

Reland of Evacuate ComputedStyle references from the CSS*Value hierarchy

Fold uses of:

  CSSPrimitiveValue::create(..., const ComputedStyle&)
  CSSValuePair::create(..., const ComputedStyle&)

into the (few) users. Handle the fall-out.

Committed: https://crrev.com/387c6ce76fad096629ad93f3ac75c7ff9f0a51fd
Cr-Commit-Position: refs/heads/master@{#419390}

[fs, 2016-09-16 14:40:45]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 14:41:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-09-16 15:33:19]

fs@opera.com changed reviewers:
+ sashab@chromium.org, timloh@chromium.org

[commit-bot: I haz the power, 2016-09-16 16:25:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 16:25:47]

Dry run: This issue passed the CQ dry run.

[Timothy Loh, 2016-09-17 08:02:07]

On 2016/09/16 15:33:19, fs wrote:

lgtm

[fs, 2016-09-17 16:22:40]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-09-17 16:22:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 20:17:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-17 20:20:13]

Description was changed from

==========
Evacuate ComputedStyle references from the CSS*Value hierarchy

Fold uses of:

  CSSPrimitiveValue::create(..., const ComputedStyle&)
  CSSValuePair::create(..., const ComputedStyle&)

into the (few) users. Handle the fall-out.
==========

to

==========
Evacuate ComputedStyle references from the CSS*Value hierarchy

Fold uses of:

  CSSPrimitiveValue::create(..., const ComputedStyle&)
  CSSValuePair::create(..., const ComputedStyle&)

into the (few) users. Handle the fall-out.

Committed: https://crrev.com/ba9df880383908b052d5a7d00abb32deec94cfc5
Cr-Commit-Position: refs/heads/master@{#419382}
==========

[commit-bot: I haz the power, 2016-09-17 20:20:15]

Patchset 1 (id:??) landed as
https://crrev.com/ba9df880383908b052d5a7d00abb32deec94cfc5
Cr-Commit-Position: refs/heads/master@{#419382}

[Avi (use Gerrit), 2016-09-17 20:43:52]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2343343002/ by avi@chromium.org.

The reason for reverting is: Tree is red; this patch fails to compile:

../../third_party/WebKit/Source/core/css/CSSValuePair.h:42:12: error: incomplete
result type 'WTF::String' in function definition
    String customCSSText() const
.

[fs, 2016-09-17 21:33:36]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-17 21:33:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 22:55:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 22:55:48]

Dry run: This issue passed the CQ dry run.

[fs, 2016-09-17 23:14:38]

Description was changed from

==========
Evacuate ComputedStyle references from the CSS*Value hierarchy

Fold uses of:

  CSSPrimitiveValue::create(..., const ComputedStyle&)
  CSSValuePair::create(..., const ComputedStyle&)

into the (few) users. Handle the fall-out.

Committed: https://crrev.com/ba9df880383908b052d5a7d00abb32deec94cfc5
Cr-Commit-Position: refs/heads/master@{#419382}
==========

to

==========
Evacuate ComputedStyle references from the CSS*Value hierarchy

Fold uses of:

  CSSPrimitiveValue::create(..., const ComputedStyle&)
  CSSValuePair::create(..., const ComputedStyle&)

into the (few) users. Handle the fall-out.
==========

[fs, 2016-09-17 23:14:55]

Description was changed from

==========
Evacuate ComputedStyle references from the CSS*Value hierarchy

Fold uses of:

  CSSPrimitiveValue::create(..., const ComputedStyle&)
  CSSValuePair::create(..., const ComputedStyle&)

into the (few) users. Handle the fall-out.
==========

to

==========
Reland of Evacuate ComputedStyle references from the CSS*Value hierarchy

Fold uses of:

  CSSPrimitiveValue::create(..., const ComputedStyle&)
  CSSValuePair::create(..., const ComputedStyle&)

into the (few) users. Handle the fall-out.
==========

[fs, 2016-09-17 23:16:22]

On 2016/09/17 at 20:43:52, avi wrote:
> A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2343343002/ by avi@chromium.org.
> 
> The reason for reverting is: Tree is red; this patch fails to compile:
> 
> ../../third_party/WebKit/Source/core/css/CSSValuePair.h:42:12: error:
incomplete result type 'WTF::String' in function definition
>     String customCSSText() const
> .

Relanding w/ inclusion of WTFString.h added to CSSValuePair.h

[fs, 2016-09-17 23:16:29]

The CQ bit was checked by fs@opera.com

[fs, 2016-09-17 23:16:30]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2345893004/#ps20001
(title: "Include WTFString.h in CSSValuePair.h")

[commit-bot: I haz the power, 2016-09-17 23:16:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 23:21:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-17 23:23:29]

Description was changed from

==========
Reland of Evacuate ComputedStyle references from the CSS*Value hierarchy

Fold uses of:

  CSSPrimitiveValue::create(..., const ComputedStyle&)
  CSSValuePair::create(..., const ComputedStyle&)

into the (few) users. Handle the fall-out.
==========

to

==========
Reland of Evacuate ComputedStyle references from the CSS*Value hierarchy

Fold uses of:

  CSSPrimitiveValue::create(..., const ComputedStyle&)
  CSSValuePair::create(..., const ComputedStyle&)

into the (few) users. Handle the fall-out.

Committed: https://crrev.com/387c6ce76fad096629ad93f3ac75c7ff9f0a51fd
Cr-Commit-Position: refs/heads/master@{#419390}
==========

[commit-bot: I haz the power, 2016-09-17 23:23:30]

Patchset 2 (id:??) landed as
https://crrev.com/387c6ce76fad096629ad93f3ac75c7ff9f0a51fd
Cr-Commit-Position: refs/heads/master@{#419390}