Views: Draw Textfield selected text in gray when top-level Widget loses focus.

ui/views/focus/focus_traversal_unittest.cc

Index: ui/views/focus/focus_traversal_unittest.cc
diff --git a/ui/views/focus/focus_traversal_unittest.cc b/ui/views/focus/focus_traversal_unittest.cc
index 1bf6ebccd3aa234598892b4d3ca8a172515acc18..afeaf97fb51b6b5a0e9b1d277dce00bbc60bdcb1 100644
--- a/ui/views/focus/focus_traversal_unittest.cc
+++ b/ui/views/focus/focus_traversal_unittest.cc
@@ -137,7 +137,15 @@ class BorderView : public NativeViewHost {
     SetFocusBehavior(FocusBehavior::NEVER);
   }
 
-  ~BorderView() override {}
+  ~BorderView() override {
+#if !defined(OS_MACOSX)
+    // TYPE_CONTROL Widget close order is different on macOS vs Windows/Linux.

[tapted, 2016/11/07 06:14:50]

We generally need platforms to behave the same - there may be a hidden bug here.


There's a comment in

void BridgedNativeWidget::RemoveOrDestroyChildren() {
  // TODO(tapted): Implement unowned child windows if required.
  while (!child_windows_.empty()) {

But I don't think that's it.

NativeWidgetAura distinguishes between owned and unowned widgets via
aura::Window::owned_by_parent_. This is set to false by the NativeViewHostAura
constructor. But on Mac, NSWindow (i.e. Mac's aura::Window equivalent) is
reference counted, so the concept at this level shouldn't apply.

[Patti Lor, 2016/11/08 01:47:31]

Deleted as discussed offline.

+    // On macOS, |widget_|'s native widget will be destroyed by the time this
+    // destructor is reached, so avoid possible use-after-frees on it (see
+    // Widget::CloseNow()) by calling this only on Windows and Linux.
+    widget_->CloseNow();
+#endif
+  }
 
   virtual internal::RootView* GetContentsRootView() {
     return static_cast<internal::RootView*>(widget_->GetRootView());