Views: Draw Textfield selected text in gray when top-level Widget loses focus.

ui/views/focus/focus_traversal_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 119 matching lines @@
 // BorderView is a view containing a native window with its own view hierarchy.
 // It is interesting to test focus traversal from a view hierarchy to an inner
 // view hierarchy.
 class BorderView : public NativeViewHost {
  public:
   explicit BorderView(View* child) : child_(child), widget_(NULL) {
     DCHECK(child);
     SetFocusBehavior(FocusBehavior::NEVER);
   }
 
-  ~BorderView() override {}
+  ~BorderView() override {
+#if !defined(OS_MACOSX)
+    // TYPE_CONTROL Widget close order is different on macOS vs Windows/Linux.

[tapted, 2016/11/07 06:14:50]

We generally need platforms to behave the same - there may be a hidden bug here.


There's a comment in

void BridgedNativeWidget::RemoveOrDestroyChildren() {
  // TODO(tapted): Implement unowned child windows if required.
  while (!child_windows_.empty()) {

But I don't think that's it.

NativeWidgetAura distinguishes between owned and unowned widgets via
aura::Window::owned_by_parent_. This is set to false by the NativeViewHostAura
constructor. But on Mac, NSWindow (i.e. Mac's aura::Window equivalent) is
reference counted, so the concept at this level shouldn't apply.

[Patti Lor, 2016/11/08 01:47:31]

Deleted as discussed offline.

+    // On macOS, |widget_|'s native widget will be destroyed by the time this
+    // destructor is reached, so avoid possible use-after-frees on it (see
+    // Widget::CloseNow()) by calling this only on Windows and Linux.
+    widget_->CloseNow();
+#endif
+  }
 
   virtual internal::RootView* GetContentsRootView() {
     return static_cast<internal::RootView*>(widget_->GetRootView());
   }
 
   FocusTraversable* GetFocusTraversable() override {
     return static_cast<internal::RootView*>(widget_->GetRootView());
   }
 
   void ViewHierarchyChanged(
       const ViewHierarchyChangedDetails& details) override {
     NativeViewHost::ViewHierarchyChanged(details);
 
     if (details.child == this && details.is_add) {
       if (!widget_) {
         widget_ = new Widget;
         Widget::InitParams params(Widget::InitParams::TYPE_CONTROL);
         params.parent = details.parent->GetWidget()->GetNativeView();
         widget_->Init(params);
         widget_->SetFocusTraversableParentView(this);
         widget_->SetContentsView(child_);
       }
 
       // We have been added to a view hierarchy, attach the native view.
       Attach(widget_->GetNativeView());

[tapted, 2016/11/07 06:14:50]

Note there's some weirdness that starts because of this line.

`GetNativeView()` is owned by BOTH |widget_| AND BorderView after this call.

And that's OK. NativeViewHostMac::native_view is a scoped_nsobject, so
GetNativeView() is reference counted -- it's possible for it to have two owners.

There is also the complication that |widget_| is owned by
`details.parent->GetWidget()`. That means that details.parent->GetWidget() but
be destroyed AFTER |this|, since |this| only has a weak pointer to |widget_|.

[Patti Lor, 2016/11/08 01:47:31]

Acknowledged.

       // Also update the FocusTraversable parent so the focus traversal works.
       static_cast<internal::RootView*>(widget_->GetRootView())->
           SetFocusTraversableParent(GetWidget()->GetFocusTraversable());
     }
   }
 
  private:
   View* child_;
   Widget* widget_;
 
@@ skipping 703 matching lines @@
   GetFocusManager()->AdvanceFocus(false);
   EXPECT_FALSE(GetFocusManager()->GetFocusedView());
 
   // Advance backwards from the root node.
   GetFocusManager()->ClearFocus();
   GetFocusManager()->AdvanceFocus(true);
   EXPECT_FALSE(GetFocusManager()->GetFocusedView());
 }
 
 }  // namespace views