Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Issue 2345133002: Offline Pages: Removes the metadata consistency check from the model API. (Closed)

Created:
4 years, 3 months ago by dewittj
Modified:
4 years, 3 months ago
Reviewers:
romax, fgorski
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Offline Pages: Removes the metadata consistency check from the model API. This check is implementation-dependent (and unused outside the model). As such it belongs only inside the offline page model. BUG=622763 Committed: https://crrev.com/e33be0330905a74f956c8563fee470cafc47ce7b Cr-Commit-Position: refs/heads/master@{#420700}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -37 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java View 1 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_bridge.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_bridge.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M components/offline_pages/offline_page_model.h View 1 chunk +0 lines, -7 lines 0 comments Download
M components/offline_pages/offline_page_model_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/offline_pages/offline_page_model_impl.cc View 1 1 chunk +1 line, -6 lines 0 comments Download
M components/offline_pages/offline_page_model_impl_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M components/offline_pages/stub_offline_page_model.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/offline_pages/stub_offline_page_model.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
dewittj
4 years, 3 months ago (2016-09-23 17:50:08 UTC) #7
fgorski
lgtm
4 years, 3 months ago (2016-09-23 18:25:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345133002/20001
4 years, 3 months ago (2016-09-23 19:36:55 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-23 19:44:30 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 19:47:28 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e33be0330905a74f956c8563fee470cafc47ce7b
Cr-Commit-Position: refs/heads/master@{#420700}

Powered by Google App Engine
This is Rietveld 408576698