components/offline_pages/offline_page_model_impl.cc - Issue 2345133002: Offline Pages: Removes the metadata consistency check from the model API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_model_impl.cc

Issue 2345133002: Offline Pages: Removes the metadata consistency check from the model API. (Closed)

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/offline_page_model_impl.cc

diff --git a/components/offline_pages/offline_page_model_impl.cc b/components/offline_pages/offline_page_model_impl.cc

index 9b142c55a4846fa368b13fcc5c07be4f572c5407..df2e5ac6d2ce44c52244ae312100649101cc7f3b 100644

--- a/components/offline_pages/offline_page_model_impl.cc

+++ b/components/offline_pages/offline_page_model_impl.cc

@@ -655,12 +655,7 @@ const OfflinePageItem* OfflinePageModelImpl::MaybeGetBestPageForOnlineURL(

}

void OfflinePageModelImpl::CheckMetadataConsistency() {

- RunWhenLoaded(

- base::Bind(&OfflinePageModelImpl::CheckMetadataConsistencyWhenLoadDone,

- weak_ptr_factory_.GetWeakPtr()));

-void OfflinePageModelImpl::CheckMetadataConsistencyWhenLoadDone() {

+ DCHECK(is_loaded_);

archive_manager_->GetAllArchives(

base::Bind(&OfflinePageModelImpl::CheckMetadataConsistencyForArchivePaths,

weak_ptr_factory_.GetWeakPtr()));