Issue 23451030: Revert 222168 "Add a CodeToNativeKeycode helper that converts UI..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23451030: Revert 222168 "Add a CodeToNativeKeycode helper that converts UI..." (Closed)

Created:
7 years, 3 months ago by Nico

Modified:
7 years, 3 months ago

Reviewers:
weitao

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 222168 "Add a CodeToNativeKeycode helper that converts UI..." UsbKeycodeMap.Basic consistently fails on the Win7 dbg main waterfall bot: http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1) base\keycodes\usb_keycode_map_unittest.cc(36): error: Value of: "Unidentified" Actual: 00890D98 Expected: InvalidKeyboardEventCode() Which is: 007F90D4 > Add a CodeToNativeKeycode helper that converts UIEvent code to native code. > Also add a SimulateKeyPress helper for browser_tests that takes both a UIEvent |code| and a ui::KeyboardCode. > > issue=284754 > > Review URL: https://chromiumcodereview.appspot.com/23542008 TBR=weitaosu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222199

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -126 lines)			Patch
M	trunk/src/content/public/test/browser_test_utils.h	View	1 chunk	+1 line, -26 lines	0 comments	Download
M	trunk/src/content/public/test/browser_test_utils.cc	View	4 chunks	+9 lines, -54 lines	0 comments	Download
M	trunk/src/remoting/test/remote_desktop_browsertest.h	View	1 chunk	+7 lines, -7 lines	0 comments	Download
M	trunk/src/remoting/test/remote_desktop_browsertest.cc	View	2 chunks	+94 lines, -10 lines	0 comments	Download
M	trunk/src/ui/base/keycodes/usb_keycode_map.h	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	trunk/src/ui/base/keycodes/usb_keycode_map_unittest.cc	View	2 chunks	+0 lines, -14 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r222199.