Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2345063003: [User Menu] Flipped the profile badge to be on the LHS for RTL layouts (Closed)

Created:
4 years, 3 months ago by anthonyvd
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[User Menu] Flipped the profile badge to be on the LHS for RTL layouts Discussed with bettes@ to decide that the profile badge on RTL layouts should be on the LHS instead. Also fixed the position of the circular mask for profile icon on RTL layouts (see first bug) - the circular mask needs to be bumped to the right on RTL layouts so that it's right-aligned. See comparative screenshots: https://drive.google.com/drive/folders/0B7Fvv7JszRyGN1FKakw4RXE2Vkk?usp=sharing BUG=640907 BUG=615893 Review-Url: https://codereview.chromium.org/2285413002 Cr-Commit-Position: refs/heads/master@{#415338} (cherry picked from commit bc337a09e7187b86f0fae15e2ff6f66e28246be8) Committed: https://chromium.googlesource.com/chromium/src/+/ba01d0f8a7b9fa09457807ee6f83401b5b04e18c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17 lines) Patch
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 4 chunks +9 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
anthonyvd
4 years, 3 months ago (2016-09-16 15:21:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ba01d0f8a7b9fa09457807ee6f83401b5b04e18c.

Powered by Google App Engine
This is Rietveld 408576698