[User Menu] Flipped the profile badge to be on the LHS for RTL layouts

[User Menu] Flipped the profile badge to be on the LHS for RTL layouts

Discussed with bettes@ to decide that the profile badge on RTL layouts
should be on the LHS instead.
Also fixed the position of the circular mask for profile icon on RTL
layouts (see first bug) - the circular mask needs to be bumped to the
right on RTL layouts so that it's right-aligned.

See comparative screenshots:
https://drive.google.com/drive/folders/0B7Fvv7JszRyGN1FKakw4RXE2Vkk?usp=sharing

BUG=640907
BUG=615893
Committed: https://crrev.com/bc337a09e7187b86f0fae15e2ff6f66e28246be8
Cr-Commit-Position: refs/heads/master@{#415338}

[anthonyvd, 2016-08-29 21:20:27]

anthonyvd@chromium.org changed reviewers:
+ sky@chromium.org

[anthonyvd, 2016-08-29 21:20:28]

Hi sky@,

This is a reupload of https://codereview.chromium.org/2286813002 (Jane's
internship is over unfortunately) that addresses the comments you had over
there. Can you PTAL?

Thanks a lot!

[sky, 2016-08-29 22:38:09]

https://codereview.chromium.org/2285413002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/2285413002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:397: void
OnPaint(gfx::Canvas* canvas) override {
AFAICT this override isn't necessary. Am I missing something?

[anthonyvd, 2016-08-30 14:31:31]

https://codereview.chromium.org/2285413002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/2285413002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:397: void
OnPaint(gfx::Canvas* canvas) override {
On 2016/08/29 at 22:38:09, sky wrote:
> AFAICT this override isn't necessary. Am I missing something?

You're absolutely right, thanks!

Done.

[sky, 2016-08-30 16:39:54]

LGTM

[anthonyvd, 2016-08-30 16:46:22]

The CQ bit was checked by anthonyvd@chromium.org

[commit-bot: I haz the power, 2016-08-30 16:46:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 17:34:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-30 17:37:27]

Description was changed from

==========
[User Menu] Flipped the profile badge to be on the LHS for RTL layouts

Discussed with bettes@ to decide that the profile badge on RTL layouts
should be on the LHS instead.
Also fixed the position of the circular mask for profile icon on RTL
layouts (see first bug) - the circular mask needs to be bumped to the
right on RTL layouts so that it's right-aligned.

See comparative screenshots:
https://drive.google.com/drive/folders/0B7Fvv7JszRyGN1FKakw4RXE2Vkk?usp=sharing

BUG=640907
BUG=615893
==========

to

==========
[User Menu] Flipped the profile badge to be on the LHS for RTL layouts

Discussed with bettes@ to decide that the profile badge on RTL layouts
should be on the LHS instead.
Also fixed the position of the circular mask for profile icon on RTL
layouts (see first bug) - the circular mask needs to be bumped to the
right on RTL layouts so that it's right-aligned.

See comparative screenshots:
https://drive.google.com/drive/folders/0B7Fvv7JszRyGN1FKakw4RXE2Vkk?usp=sharing

BUG=640907
BUG=615893

Committed: https://crrev.com/bc337a09e7187b86f0fae15e2ff6f66e28246be8
Cr-Commit-Position: refs/heads/master@{#415338}
==========

[commit-bot: I haz the power, 2016-08-30 17:37:28]

Patchset 3 (id:??) landed as
https://crrev.com/bc337a09e7187b86f0fae15e2ff6f66e28246be8
Cr-Commit-Position: refs/heads/master@{#415338}