content/public/browser/navigation_handle.cc - Issue 2345053006: Remove IsSynchronous API from NavigationHandle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/navigation_handle.cc

Issue 2345053006: Remove IsSynchronous API from NavigationHandle. (Closed)

Patch Set: Use the renderer value for same_page on handles created during commit. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/navigation_handle.cc

diff --git a/content/public/browser/navigation_handle.cc b/content/public/browser/navigation_handle.cc

index 723593a78b95ca12122003d5cd25bd44c8b8ccd9..076d048a2999b8216c625565c85c1ffbd837ab5b 100644

--- a/content/public/browser/navigation_handle.cc

+++ b/content/public/browser/navigation_handle.cc

@@ -30,7 +30,7 @@ NavigationHandle::CreateNavigationHandleForTesting(

url, static_cast<RenderFrameHostImpl*>(render_frame_host)

->frame_tree_node(),

true, // is_renderer_initiated

- false, // is_synchronous

+ false, // is_same_page

false, // is_srcdoc

base::TimeTicks::Now(), 0);

return std::unique_ptr<NavigationHandle>(std::move(handle_impl));