Remove IsSynchronous API from NavigationHandle.

content/browser/frame_host/render_frame_host_impl.cc

Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 01bf05f44b1f5af42dec7efc152ff2bc1a5ddd88..c4bde52b03e176055416144e456672353cfbf9bd 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -1218,7 +1218,7 @@ void RenderFrameHostImpl::OnDidCommitProvisionalLoad(const IPC::Message& msg) {
     navigation_handle_ = NavigationHandleImpl::Create(
         validated_params.url, frame_tree_node_,
         is_renderer_initiated,
-        true,  // is_synchronous
+        validated_params.was_within_same_page,

[Charlie Reis, 2016/09/16 22:23:53]

I don't understand this change.  When is this false?

[nasko, 2016/09/16 23:38:11]

Unfortunately, there are some cases where this is false:
* loading of data URL with base URL - the URL in the handle is the base URL and
the committed URL is the real data URL.
* blocking a document load due to CSP - the URL in the handle is the real URL we
started loading, but when blocked, we load "data:," into the frame and that
comes as the committed URL.

These cases cause the code above, on line 1208, to reset the existing
navigation_handle_. So going into this branch, we assume it is a synchronous
load, even though it isn't. Using validated_params.was_within_same_page accounts
for those cases as it has the correct value passed by the renderer.

[Charlie Reis, 2016/09/16 23:59:16]

Thanks!  That clarifies it.  Can you update the comment on line 1211, since this
block is not just about synchronous navigations?

[nasko, 2016/09/20 23:11:20]

Tried to clarify both this comment and the one above.

         validated_params.is_srcdoc, base::TimeTicks::Now(),
         entry_id_for_data_nav);
     // PlzNavigate