content/browser/frame_host/navigation_handle_impl.h - Issue 2345053006: Remove IsSynchronous API from NavigationHandle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 2345053006: Remove IsSynchronous API from NavigationHandle. (Closed)

Patch Set: Addressed review comments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/supervised_user_navigation_observer.cc ('k') | content/browser/frame_host/navigation_handle_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_handle_impl.h

diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h

index 58aff96b249dfb6a28b8b30a6bf62f8543029eda..e80ee36b68505fa3caac28890d8ec6204697cba6 100644

--- a/content/browser/frame_host/navigation_handle_impl.h

+++ b/content/browser/frame_host/navigation_handle_impl.h

@@ -77,7 +77,7 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {

const GURL& url,

FrameTreeNode* frame_tree_node,

bool is_renderer_initiated,

- bool is_synchronous,

+ bool is_same_page,

bool is_srcdoc,

const base::TimeTicks& navigation_start,

int pending_nav_entry_id,

@@ -90,7 +90,6 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {

bool IsInMainFrame() override;

bool IsParentMainFrame() override;

bool IsRendererInitiated() override;

- bool IsSynchronousNavigation() override;

bool IsSrcdoc() override;

bool WasServerRedirect() override;

int GetFrameTreeNodeId() override;

@@ -300,7 +299,7 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {

NavigationHandleImpl(const GURL& url,

FrameTreeNode* frame_tree_node,

bool is_renderer_initiated,

- bool is_synchronous,

+ bool is_same_page,

bool is_srcdoc,

const base::TimeTicks& navigation_start,

int pending_nav_entry_id,

@@ -343,8 +342,7 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {

net::Error net_error_code_;

RenderFrameHostImpl* render_frame_host_;

const bool is_renderer_initiated_;

- bool is_same_page_;

- const bool is_synchronous_;

+ const bool is_same_page_;

const bool is_srcdoc_;

bool was_redirected_;

scoped_refptr<net::HttpResponseHeaders> response_headers_;