chrome/browser/supervised_user/supervised_user_navigation_observer.cc - Issue 2345053006: Remove IsSynchronous API from NavigationHandle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/supervised_user_navigation_observer.cc

Issue 2345053006: Remove IsSynchronous API from NavigationHandle. (Closed)

Patch Set: Addressed review comments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ssl/chrome_security_state_model_client.cc ('k') | content/browser/frame_host/navigation_handle_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/supervised_user_navigation_observer.cc

diff --git a/chrome/browser/supervised_user/supervised_user_navigation_observer.cc b/chrome/browser/supervised_user/supervised_user_navigation_observer.cc

index 90edc77c43c00592d65b5cd01c3b9675b3f0dc36..6bf7795a141654f922327269845a380450ec7976 100644

--- a/chrome/browser/supervised_user/supervised_user_navigation_observer.cc

+++ b/chrome/browser/supervised_user/supervised_user_navigation_observer.cc

@@ -66,9 +66,9 @@ void SupervisedUserNavigationObserver::OnRequestBlocked(

void SupervisedUserNavigationObserver::DidFinishNavigation(

content::NavigationHandle* navigation_handle) {

- // Only filter synchronous navigations (eg. pushState/popState); others will

+ // Only filter same page navigations (eg. pushState/popState); others will

// have been filtered by the ResourceThrottle.

- if (!navigation_handle->IsSynchronousNavigation())

+ if (!navigation_handle->IsSamePage())

return;

if (!navigation_handle->IsInMainFrame())

« no previous file with comments | « chrome/browser/ssl/chrome_security_state_model_client.cc ('k') | content/browser/frame_host/navigation_handle_impl.h » ('j') | no next file with comments »