Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2345053002: Revert of Add CastMediaBlocker and BrowserTest (Closed)

Created:
4 years, 3 months ago by jbroman
Modified:
4 years, 3 months ago
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add CastMediaBlocker and BrowserTest (patchset #5 id:80001 of https://codereview.chromium.org/2330243002/ ) Reason for revert: Test is failing on Cast Linux: https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/31563 Original issue's description: > Add CastMediaBlocker and BrowserTest > > CastMediaBlocker is a class which can prevent media from being played > on a web page. > > BUG=NONE > TEST=ChromecastShellMediaBlockingBrowserTest > > Committed: https://crrev.com/502bcc946bd12e907572f8b22ef4a0abbc8190d0 > Cr-Commit-Position: refs/heads/master@{#418897} TBR=halliwell@chromium.org,byungchul@chromium.org,derekjchow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=NONE Committed: https://crrev.com/08f159868ca7dcbb08af94e27b056ac4d995f12d Cr-Commit-Position: refs/heads/master@{#418950}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -226 lines) Patch
M chromecast/browser/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D chromecast/browser/cast_media_blocker.h View 1 chunk +0 lines, -62 lines 0 comments Download
D chromecast/browser/cast_media_blocker.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M chromecast/browser/test/chromecast_browser_test_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/browser/test/chromecast_browser_test_helper_default.cc View 3 chunks +0 lines, -7 lines 0 comments Download
D chromecast/browser/test/chromecast_shell_media_blocking_browser_test.cc View 1 chunk +0 lines, -95 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jbroman
Created Revert of Add CastMediaBlocker and BrowserTest
4 years, 3 months ago (2016-09-15 20:16:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345053002/1
4 years, 3 months ago (2016-09-15 20:17:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 20:17:59 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 20:20:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08f159868ca7dcbb08af94e27b056ac4d995f12d
Cr-Commit-Position: refs/heads/master@{#418950}

Powered by Google App Engine
This is Rietveld 408576698