Source/modules/imagebitmap/ImageBitmapFactories.cpp - Issue 23450039: Pass isolate to ScriptValue constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/imagebitmap/ImageBitmapFactories.cpp

Issue 23450039: Pass isolate to ScriptValue constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove useless member Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/imagebitmap/ImageBitmapFactories.cpp

diff --git a/Source/modules/imagebitmap/ImageBitmapFactories.cpp b/Source/modules/imagebitmap/ImageBitmapFactories.cpp

index 14a826955cfce1e6cf72f8ea9fa76e88289b0a38..76ae2684c4b977a173a58addfeb3df5a1f09ec4f 100644

--- a/Source/modules/imagebitmap/ImageBitmapFactories.cpp

+++ b/Source/modules/imagebitmap/ImageBitmapFactories.cpp

@@ -318,8 +318,9 @@ void ImageBitmapFactories::ImageBitmapLoader::loadBlobAsync(ScriptExecutionConte

void ImageBitmapFactories::ImageBitmapLoader::rejectPromise()

{

+ v8::Isolate* isolate = m_scriptState->isolate();

ScriptScope scope(m_scriptState);

- m_resolver->reject(ScriptValue::createNull());

+ m_resolver->reject(ScriptValue(v8::Null(isolate), isolate));

m_factory->didFinishLoading(this);

}