Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: Source/bindings/v8/WorkerScriptController.cpp

Issue 23450039: Pass isolate to ScriptValue constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove useless member Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/WorkerScriptController.cpp
diff --git a/Source/bindings/v8/WorkerScriptController.cpp b/Source/bindings/v8/WorkerScriptController.cpp
index dbe4578ab96632d50329a740d4f9f7d16c9d3d8c..83ba3a78a34c5da41229e1b5a0c414cf6a9c079e 100644
--- a/Source/bindings/v8/WorkerScriptController.cpp
+++ b/Source/bindings/v8/WorkerScriptController.cpp
@@ -168,7 +168,7 @@ ScriptValue WorkerScriptController::evaluate(const String& script, const String&
state->lineNumber = message->GetLineNumber();
state->columnNumber = message->GetStartColumn();
state->sourceURL = toWebCoreString(message->GetScriptResourceName());
- state->exception = ScriptValue(block.Exception());
+ state->exception = ScriptValue(block.Exception(), m_isolate);
block.Reset();
} else
state->hadException = false;
@@ -176,7 +176,7 @@ ScriptValue WorkerScriptController::evaluate(const String& script, const String&
if (result.IsEmpty() || result->IsUndefined())
return ScriptValue();
- return ScriptValue(result);
+ return ScriptValue(result, m_isolate);
}
void WorkerScriptController::evaluate(const ScriptSourceCode& sourceCode, RefPtr<ErrorEvent>* errorEvent)

Powered by Google App Engine
This is Rietveld 408576698