Source/bindings/v8/ScriptValue.cpp - Issue 23450039: Pass isolate to ScriptValue constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptValue.cpp

Issue 23450039: Pass isolate to ScriptValue constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove useless member Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptValue.cpp

diff --git a/Source/bindings/v8/ScriptValue.cpp b/Source/bindings/v8/ScriptValue.cpp

index b342697e1a64862b83b6e02b902417371b0f60f0..df244dcfeaef4511301608f0a2c14f3a198eef42 100644

--- a/Source/bindings/v8/ScriptValue.cpp

+++ b/Source/bindings/v8/ScriptValue.cpp

@@ -59,7 +59,7 @@ PassRefPtr<SerializedScriptValue> ScriptValue::serialize(ScriptState* scriptStat

ScriptValue ScriptValue::deserialize(ScriptState* scriptState, SerializedScriptValue* value)

{

ScriptScope scope(scriptState);

- return ScriptValue(value->deserialize());

+ return ScriptValue(value->deserialize(), scriptState->isolate());

}

bool ScriptValue::getString(String& result, v8::Isolate* isolate) const