Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: Source/bindings/v8/IDBBindingUtilitiesTest.cpp

Issue 23450039: Pass isolate to ScriptValue constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/IDBBindingUtilities.cpp ('k') | Source/bindings/v8/ScriptCallStackFactory.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/IDBBindingUtilitiesTest.cpp
diff --git a/Source/bindings/v8/IDBBindingUtilitiesTest.cpp b/Source/bindings/v8/IDBBindingUtilitiesTest.cpp
index dd84bdf9d62a6687fea55bd73688a76329c70e10..510b663a879412ac1352b6d728697a1ed078ee71 100644
--- a/Source/bindings/v8/IDBBindingUtilitiesTest.cpp
+++ b/Source/bindings/v8/IDBBindingUtilitiesTest.cpp
@@ -107,7 +107,7 @@ TEST_F(IDBKeyFromValueAndKeyPathTest, TopLevelPropertyStringValue)
v8::Local<v8::Object> object = v8::Object::New();
object->Set(v8::String::New("foo"), v8::String::New("zoo"));
- ScriptValue scriptValue(object);
+ ScriptValue scriptValue(object, v8::Isolate::GetCurrent());
checkKeyPathStringValue(scriptValue, "foo", "zoo");
checkKeyPathNullValue(scriptValue, "bar");
@@ -118,7 +118,7 @@ TEST_F(IDBKeyFromValueAndKeyPathTest, TopLevelPropertyNumberValue)
v8::Local<v8::Object> object = v8::Object::New();
object->Set(v8::String::New("foo"), v8::Number::New(456));
- ScriptValue scriptValue(object);
+ ScriptValue scriptValue(object, v8::Isolate::GetCurrent());
checkKeyPathNumberValue(scriptValue, "foo", 456);
checkKeyPathNullValue(scriptValue, "bar");
@@ -131,7 +131,7 @@ TEST_F(IDBKeyFromValueAndKeyPathTest, SubProperty)
subProperty->Set(v8::String::New("bar"), v8::String::New("zee"));
object->Set(v8::String::New("foo"), subProperty);
- ScriptValue scriptValue(object);
+ ScriptValue scriptValue(object, v8::Isolate::GetCurrent());
checkKeyPathStringValue(scriptValue, "foo.bar", "zee");
checkKeyPathNullValue(scriptValue, "bar");
@@ -145,7 +145,7 @@ TEST_F(InjectIDBKeyTest, TopLevelPropertyStringValue)
v8::Local<v8::Object> object = v8::Object::New();
object->Set(v8::String::New("foo"), v8::String::New("zoo"));
- ScriptValue foozoo(object);
+ ScriptValue foozoo(object, v8::Isolate::GetCurrent());
checkInjection(IDBKey::createString("myNewKey"), foozoo, "bar");
checkInjection(IDBKey::createNumber(1234), foozoo, "bar");
@@ -159,7 +159,7 @@ TEST_F(InjectIDBKeyTest, SubProperty)
subProperty->Set(v8::String::New("bar"), v8::String::New("zee"));
object->Set(v8::String::New("foo"), subProperty);
- ScriptValue scriptObject(object);
+ ScriptValue scriptObject(object, v8::Isolate::GetCurrent());
checkInjection(IDBKey::createString("myNewKey"), scriptObject, "foo.baz");
checkInjection(IDBKey::createNumber(789), scriptObject, "foo.baz");
checkInjection(IDBKey::createDate(4567), scriptObject, "foo.baz");
« no previous file with comments | « Source/bindings/v8/IDBBindingUtilities.cpp ('k') | Source/bindings/v8/ScriptCallStackFactory.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698