Issue 23450030: Introduce Position::inDocument()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23450030: Introduce Position::inDocument() (Closed)

Created:
7 years, 3 months ago by yosin_UTC9

Modified:
7 years, 3 months ago

Reviewers:
tkent

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, groby+blinkspell_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Introduce Position::inDocument() This patch introduces Position::inDocument() to replace Position::anchorNode()->inDocument() for shorter code pattern and safety for avoiding null reference. BUG=n/a TEST=n/a; no behavior changes R=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157513

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -18 lines)			Patch
M	Source/core/dom/Position.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/editing/ApplyBlockElementCommand.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/ApplyStyleCommand.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/CompositeEditCommand.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/DeleteSelectionCommand.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/editing/Editor.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/editing/IndentOutdentCommand.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/InsertListCommand.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/InsertTextCommand.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/MoveSelectionCommand.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/ReplaceSelectionCommand.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yosin_UTC9

7 years, 3 months ago (2013-09-10 08:17:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r157513 (presubmit successful).

Expand Messages | Collapse Messages