Source/core/editing/InsertTextCommand.cpp - Issue 23450030: Introduce Position::inDocument()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/InsertTextCommand.cpp

Issue 23450030: Introduce Position::inDocument() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/InsertTextCommand.cpp

diff --git a/Source/core/editing/InsertTextCommand.cpp b/Source/core/editing/InsertTextCommand.cpp

index f8bfa596659a1885a176c5632b65c12c6394849c..2e3c45f2b8313ccd2eac88dec89586580870fc98 100644

--- a/Source/core/editing/InsertTextCommand.cpp

+++ b/Source/core/editing/InsertTextCommand.cpp

@@ -175,7 +175,7 @@ void InsertTextCommand::doApply()

// and so deleteInsignificantText could remove it. Save the position before the node in case that happens.

Position positionBeforeStartNode(positionInParentBeforeNode(startPosition.containerNode()));

deleteInsignificantText(startPosition.upstream(), startPosition.downstream());

- if (!startPosition.anchorNode()->inDocument())

+ if (!startPosition.inDocument())

startPosition = positionBeforeStartNode;

if (!startPosition.isCandidate())

startPosition = startPosition.downstream();