Issue 23450016: Re-land https://codereview.chromium.org/23602005: Use nobarrier atomics for lossy counters in base:…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23450016: Re-land https://codereview.chromium.org/23602005: Use nobarrier atomics for lossy counters in base:… (Closed)

Created:
7 years, 3 months ago by Alexander Potapenko

Modified:
7 years, 3 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, erikwright+watch_chromium.org, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Re-land https://codereview.chromium.org/23602005: Use nobarrier atomics for lossy counters in base::HistogramSamples and base::SampleVector This should not affect the performance, but will make it explicit that the counter values are expected to be read and written atomically. This will also suppress the ThreadSanitizer v2 reports on these counters. BUG=46840 TBR=jar@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221183

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -4 lines)			Patch
M	base/metrics/histogram_base.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	base/metrics/histogram_samples.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	base/metrics/sample_vector.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Alexander Potapenko

7 years, 3 months ago (2013-09-04 13:37:44 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r221183 (presubmit successful).