base/metrics/histogram_samples.cc - Issue 23450016: Re-land https://codereview.chromium.org/23602005: Use nobarrier atomics for lossy counters in base:…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_samples.cc

Issue 23450016: Re-land https://codereview.chromium.org/23602005: Use nobarrier atomics for lossy counters in base:… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/metrics/histogram_samples.cc

===================================================================

--- base/metrics/histogram_samples.cc (revision 221170)

+++ base/metrics/histogram_samples.cc (working copy)

@@ -113,7 +113,8 @@

}

void HistogramSamples::IncreaseRedundantCount(HistogramBase::Count diff) {

- redundant_count_ += diff;

+ base::subtle::NoBarrier_Store(&redundant_count_,

+ base::subtle::NoBarrier_Load(&redundant_count_) + diff);

}

SampleCountIterator::~SampleCountIterator() {}

« no previous file with comments | « base/metrics/histogram_base.h ('k') | base/metrics/sample_vector.cc » ('j') | no next file with comments »