third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h - Issue 2344983003: Merge the code paths for closing different kinds of notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h

Issue 2344983003: Merge the code paths for closing different kinds of notifications. (Closed)

Patch Set: Merge the close methods Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/public/platform/modules/notifications/WebNotificationDelegate.h ('K') | « third_party/WebKit/public/platform/modules/notifications/WebNotificationDelegate.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h

diff --git a/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h b/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h

index f5a0cc904ced876585ad8f392416c8c2b604815b..8a3edd706136459150554ef66f15093d6288770e 100644

--- a/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h

+++ b/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h

@@ -47,11 +47,8 @@ public:

// considered. Will take ownership of the WebNotificationGetCallbacks object.

virtual void getNotifications(const WebString& filterTag, WebServiceWorkerRegistration*, WebNotificationGetCallbacks*) = 0;

- // Closes a notification previously shown, and removes it if being shown.

- virtual void close(WebNotificationDelegate*) = 0;

- // Closes a persistent notification identified by its notification Id.

- virtual void closePersistent(const WebSecurityOrigin&, const WebString& tag, const WebString& notificationId) = 0;

+ // Closes a notification identified by its notification Id.

+ virtual void close(const WebSecurityOrigin&, const WebString& tag, const WebString& notificationId) = 0;

// Indicates that the delegate object is being destroyed, and must no longer

// be used by the embedder to dispatch events.