Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h

Issue 2344983003: Merge the code paths for closing different kinds of notifications. (Closed)
Patch Set: Merge the close methods Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebNotificationManager_h 5 #ifndef WebNotificationManager_h
6 #define WebNotificationManager_h 6 #define WebNotificationManager_h
7 7
8 #include "public/platform/WebCallbacks.h" 8 #include "public/platform/WebCallbacks.h"
9 #include "public/platform/WebString.h" 9 #include "public/platform/WebString.h"
10 #include "public/platform/WebVector.h" 10 #include "public/platform/WebVector.h"
(...skipping 29 matching lines...) Expand all
40 // Shows a persistent notification on the user's system. These notifications will have 40 // Shows a persistent notification on the user's system. These notifications will have
41 // their events delivered to a Service Worker rather than the object's deleg ate. Will 41 // their events delivered to a Service Worker rather than the object's deleg ate. Will
42 // take ownership of the WebNotificationShowCallbacks object. 42 // take ownership of the WebNotificationShowCallbacks object.
43 virtual void showPersistent(const WebSecurityOrigin&, const WebNotificationD ata&, std::unique_ptr<WebNotificationResources>, WebServiceWorkerRegistration*, WebNotificationShowCallbacks*) = 0; 43 virtual void showPersistent(const WebSecurityOrigin&, const WebNotificationD ata&, std::unique_ptr<WebNotificationResources>, WebServiceWorkerRegistration*, WebNotificationShowCallbacks*) = 0;
44 44
45 // Asynchronously gets the persistent notifications belonging to the Service Worker Registration. 45 // Asynchronously gets the persistent notifications belonging to the Service Worker Registration.
46 // If |filterTag| is not an empty string, only the notification with the giv en tag will be 46 // If |filterTag| is not an empty string, only the notification with the giv en tag will be
47 // considered. Will take ownership of the WebNotificationGetCallbacks object . 47 // considered. Will take ownership of the WebNotificationGetCallbacks object .
48 virtual void getNotifications(const WebString& filterTag, WebServiceWorkerRe gistration*, WebNotificationGetCallbacks*) = 0; 48 virtual void getNotifications(const WebString& filterTag, WebServiceWorkerRe gistration*, WebNotificationGetCallbacks*) = 0;
49 49
50 // Closes a notification previously shown, and removes it if being shown. 50 // Closes a notification identified by its notification Id.
51 virtual void close(WebNotificationDelegate*) = 0; 51 virtual void close(const WebSecurityOrigin&, const WebString& tag, const Web String& notificationId) = 0;
52
53 // Closes a persistent notification identified by its notification Id.
54 virtual void closePersistent(const WebSecurityOrigin&, const WebString& tag, const WebString& notificationId) = 0;
55 52
56 // Indicates that the delegate object is being destroyed, and must no longer 53 // Indicates that the delegate object is being destroyed, and must no longer
57 // be used by the embedder to dispatch events. 54 // be used by the embedder to dispatch events.
58 virtual void notifyDelegateDestroyed(WebNotificationDelegate*) = 0; 55 virtual void notifyDelegateDestroyed(WebNotificationDelegate*) = 0;
59 }; 56 };
60 57
61 } // namespace blink 58 } // namespace blink
62 59
63 #endif // WebNotificationManager_h 60 #endif // WebNotificationManager_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698