Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.h

Issue 2344983003: Merge the code paths for closing different kinds of notifications. (Closed)
Patch Set: Merge the close methods Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/notifications/Notification.h
diff --git a/third_party/WebKit/Source/modules/notifications/Notification.h b/third_party/WebKit/Source/modules/notifications/Notification.h
index 8291bdaa1e6ca1f38cabd17c5bd3eb878d41b38c..50f37792ebdcecd0498bcac576a03cd8b50215c0 100644
--- a/third_party/WebKit/Source/modules/notifications/Notification.h
+++ b/third_party/WebKit/Source/modules/notifications/Notification.h
@@ -80,10 +80,10 @@ public:
DEFINE_ATTRIBUTE_EVENT_LISTENER(close);
// WebNotificationDelegate implementation.
- void dispatchShowEvent() override;
- void dispatchClickEvent() override;
+ void didShowNotification(const WebString& notificationId) override;
+ void didClickNotification() override;
+ void didCloseNotification() override;
void dispatchErrorEvent() override;
- void dispatchCloseEvent() override;
String title() const;
String dir() const;

Powered by Google App Engine
This is Rietveld 408576698