Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: third_party/WebKit/Source/modules/notifications/Notification.h

Issue 2344983003: Merge the code paths for closing different kinds of notifications. (Closed)
Patch Set: Merge the close methods Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 ~Notification() override; 73 ~Notification() override;
74 74
75 void close(); 75 void close();
76 76
77 DEFINE_ATTRIBUTE_EVENT_LISTENER(click); 77 DEFINE_ATTRIBUTE_EVENT_LISTENER(click);
78 DEFINE_ATTRIBUTE_EVENT_LISTENER(show); 78 DEFINE_ATTRIBUTE_EVENT_LISTENER(show);
79 DEFINE_ATTRIBUTE_EVENT_LISTENER(error); 79 DEFINE_ATTRIBUTE_EVENT_LISTENER(error);
80 DEFINE_ATTRIBUTE_EVENT_LISTENER(close); 80 DEFINE_ATTRIBUTE_EVENT_LISTENER(close);
81 81
82 // WebNotificationDelegate implementation. 82 // WebNotificationDelegate implementation.
83 void dispatchShowEvent() override; 83 void didShowNotification(const WebString& notificationId) override;
84 void dispatchClickEvent() override; 84 void didClickNotification() override;
85 void didCloseNotification() override;
85 void dispatchErrorEvent() override; 86 void dispatchErrorEvent() override;
86 void dispatchCloseEvent() override;
87 87
88 String title() const; 88 String title() const;
89 String dir() const; 89 String dir() const;
90 String lang() const; 90 String lang() const;
91 String body() const; 91 String body() const;
92 String tag() const; 92 String tag() const;
93 String image() const; 93 String image() const;
94 String icon() const; 94 String icon() const;
95 String badge() const; 95 String badge() const;
96 NavigatorVibration::VibrationPattern vibrate() const; 96 NavigatorVibration::VibrationPattern vibrate() const;
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 String m_notificationId; 169 String m_notificationId;
170 170
171 Member<AsyncMethodRunner<Notification>> m_prepareShowMethodRunner; 171 Member<AsyncMethodRunner<Notification>> m_prepareShowMethodRunner;
172 172
173 Member<NotificationResourcesLoader> m_loader; 173 Member<NotificationResourcesLoader> m_loader;
174 }; 174 };
175 175
176 } // namespace blink 176 } // namespace blink
177 177
178 #endif // Notification_h 178 #endif // Notification_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698