Chromium Code Reviews| Index: tools/perf/measurements/endure.py |
| diff --git a/tools/perf/measurements/endure.py b/tools/perf/measurements/endure.py |
| index da3a1700bd6a9c67eedd6c6bfa970c6370c03f86..385d8cfbc957fb0fd13d7008296cd2856bb414a0 100644 |
| --- a/tools/perf/measurements/endure.py |
| +++ b/tools/perf/measurements/endure.py |
| @@ -123,22 +123,23 @@ class Endure(page_measurement.PageMeasurement): |
| # DOM nodes and event listeners |
| dom_node_count = tab.dom_stats['node_count'] |
| event_listener_count = tab.dom_stats['event_listener_count'] |
| - AddPoint('TotalDOMNodeCount', 'nodes', dom_node_count) |
| - AddPoint('EventListenerCount', 'events', event_listener_count) |
| + AddPoint('dom_nodes', 'count', dom_node_count) |
| + AddPoint('event_listeners', 'count', event_listener_count) |
|
Michael Achenbach
2013/09/19 10:49:04
Ignore my comment on the last CL. "count" is stric
|
| # Browser and renderer virtual memory stats |
| def BrowserVMStats(statistic_name): |
| """Get VM stats from the Browser object in KB.""" |
| return self._browser.memory_stats[statistic_name].get('VM', 0) / 1024.0 |
| - AddPoint('BrowserVirtualMemory', 'KB', BrowserVMStats('Browser')) |
| - AddPoint('RendererVirtualMemory', 'KB', BrowserVMStats('Renderer')) |
| + AddPoint('browser_vm', 'KB', BrowserVMStats('Browser')) |
| + AddPoint('renderer_vm', 'KB', BrowserVMStats('Renderer')) |
| + AddPoint('gpu_vm', 'KB', BrowserVMStats('Gpu')) |
|
Michael Achenbach
2013/09/19 10:49:04
Hope the abbreviation vm will not confuse. But I l
Michael Achenbach
2013/09/19 10:49:04
I can't say anything about the 'Gpu' string. But a
|
| # V8 stats |
| def V8StatsSum(counters): |
| """Given a list of V8 counter names, get the sum of the values in KB.""" |
| stats = v8_object_stats.V8ObjectStatsMetric.GetV8StatsTable(tab, counters) |
| return sum(stats.values()) / 1024.0 |
| - AddPoint('V8BytesCommitted', 'KB', V8StatsSum(_V8_BYTES_COMMITTED)) |
| - AddPoint('V8BytesUsed', 'KB', V8StatsSum(_V8_BYTES_USED)) |
| - AddPoint('V8MemoryAllocated', 'KB', V8StatsSum(_V8_MEMORY_ALLOCATED)) |
| + AddPoint('v8_memory_committed', 'KB', V8StatsSum(_V8_BYTES_COMMITTED)) |
| + AddPoint('v8_memory_used', 'KB', V8StatsSum(_V8_BYTES_USED)) |
| + AddPoint('v8_memory_allocated', 'KB', V8StatsSum(_V8_MEMORY_ALLOCATED)) |
|
Michael Achenbach
2013/09/19 10:49:04
Good one! Unit and trace name were not very consis
|