Endure: rename trace names, making them lowercase

tools/perf/measurements/endure.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import optparse
 import re
 import time
 
 from metrics import v8_object_stats
 from telemetry.page import page_measurement
@@ skipping 105 matching lines @@
       if seconds:
         results.Add(trace_name + '_X', 'seconds', seconds)
       else:
         assert iterations, 'Neither seconds nor iterations given.'
         results.Add(trace_name + '_X', 'seconds', iterations)
       results.Add(trace_name + '_Y', units_y, value_y)
 
     # DOM nodes and event listeners
     dom_node_count = tab.dom_stats['node_count']
     event_listener_count = tab.dom_stats['event_listener_count']
-    AddPoint('TotalDOMNodeCount', 'nodes', dom_node_count)
-    AddPoint('EventListenerCount', 'events', event_listener_count)
+    AddPoint('dom_nodes', 'count', dom_node_count)
+    AddPoint('event_listeners', 'count', event_listener_count)

[Michael Achenbach, 2013/09/19 10:49:04]

Ignore my comment on the last CL. "count" is strictly better then "events" or
"listeners", because it is more uniform and shorter.

 
     # Browser and renderer virtual memory stats
     def BrowserVMStats(statistic_name):
       """Get VM stats from the Browser object in KB."""
       return self._browser.memory_stats[statistic_name].get('VM', 0) / 1024.0
-    AddPoint('BrowserVirtualMemory', 'KB', BrowserVMStats('Browser'))
-    AddPoint('RendererVirtualMemory', 'KB', BrowserVMStats('Renderer'))
+    AddPoint('browser_vm', 'KB', BrowserVMStats('Browser'))
+    AddPoint('renderer_vm', 'KB', BrowserVMStats('Renderer'))
+    AddPoint('gpu_vm', 'KB', BrowserVMStats('Gpu'))

[Michael Achenbach, 2013/09/19 10:49:04]

Hope the abbreviation vm will not confuse. But I like it, since it's short.

[Michael Achenbach, 2013/09/19 10:49:04]

I can't say anything about the 'Gpu' string. But adding more stats is always
good.

 
     # V8 stats
     def V8StatsSum(counters):
       """Given a list of V8 counter names, get the sum of the values in KB."""
       stats = v8_object_stats.V8ObjectStatsMetric.GetV8StatsTable(tab, counters)
       return sum(stats.values()) / 1024.0
-    AddPoint('V8BytesCommitted', 'KB', V8StatsSum(_V8_BYTES_COMMITTED))
-    AddPoint('V8BytesUsed', 'KB', V8StatsSum(_V8_BYTES_USED))
-    AddPoint('V8MemoryAllocated', 'KB', V8StatsSum(_V8_MEMORY_ALLOCATED))
+    AddPoint('v8_memory_committed', 'KB', V8StatsSum(_V8_BYTES_COMMITTED))
+    AddPoint('v8_memory_used', 'KB', V8StatsSum(_V8_BYTES_USED))
+    AddPoint('v8_memory_allocated', 'KB', V8StatsSum(_V8_MEMORY_ALLOCATED))

[Michael Achenbach, 2013/09/19 10:49:04]

Good one! Unit and trace name were not very consistent anyway.