Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 23449041: Endure: rename trace names, making them lowercase (Closed)

Created:
7 years, 3 months ago by qyearsley
Modified:
7 years, 2 months ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Visibility:
Public.

Description

Endure: rename trace names, making them lowercase BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226400

Patch Set 1 #

Total comments: 4

Patch Set 2 : Merge patches to previous (already committed CL #

Patch Set 3 : Merge changes from committed CL 23645013 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M tools/perf/measurements/endure.py View 1 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
qyearsley
Make the trace names lowercase to be more consistent with the trace names for the ...
7 years, 3 months ago (2013-09-19 00:28:15 UTC) #1
Michael Achenbach
lgtm https://codereview.chromium.org/23449041/diff/1/tools/perf/measurements/endure.py File tools/perf/measurements/endure.py (right): https://codereview.chromium.org/23449041/diff/1/tools/perf/measurements/endure.py#newcode127 tools/perf/measurements/endure.py:127: AddPoint('event_listeners', 'count', event_listener_count) Ignore my comment on the ...
7 years, 3 months ago (2013-09-19 10:49:04 UTC) #2
qyearsley
Dave, could you take a look at this one?
7 years, 2 months ago (2013-09-25 17:18:29 UTC) #3
dtu
lgtm
7 years, 2 months ago (2013-09-26 21:15:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qyearsley@chromium.org/23449041/1
7 years, 2 months ago (2013-09-26 21:18:02 UTC) #5
commit-bot: I haz the power
Failed to apply patch for tools/perf/measurements/endure.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-09-26 21:18:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qyearsley@chromium.org/23449041/13001
7 years, 2 months ago (2013-10-01 20:42:15 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=84673
7 years, 2 months ago (2013-10-01 22:43:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qyearsley@chromium.org/23449041/13001
7 years, 2 months ago (2013-10-02 01:08:30 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 06:43:38 UTC) #10
Message was sent while issue was closed.
Change committed as 226400

Powered by Google App Engine
This is Rietveld 408576698