Endure: rename trace names, making them lowercase

Endure: rename trace names, making them lowercase

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226400

[qyearsley, 2013-09-19 00:28:15]

Make the trace names lowercase to be more consistent with the trace names for
the other measurements.

Additionally, I changed some of the names slightly. Do these changes seem good?

Also: Added collection of GPU VM stat; not sure if this will be useful.

[Michael Achenbach, 2013-09-19 10:49:04]

lgtm

https://codereview.chromium.org/23449041/diff/1/tools/perf/measurements/endur...
File tools/perf/measurements/endure.py (right):

https://codereview.chromium.org/23449041/diff/1/tools/perf/measurements/endur...
tools/perf/measurements/endure.py:127: AddPoint('event_listeners', 'count',
event_listener_count)
Ignore my comment on the last CL. "count" is strictly better then "events" or
"listeners", because it is more uniform and shorter.

https://codereview.chromium.org/23449041/diff/1/tools/perf/measurements/endur...
tools/perf/measurements/endure.py:135: AddPoint('gpu_vm', 'KB',
BrowserVMStats('Gpu'))
Hope the abbreviation vm will not confuse. But I like it, since it's short.

https://codereview.chromium.org/23449041/diff/1/tools/perf/measurements/endur...
tools/perf/measurements/endure.py:135: AddPoint('gpu_vm', 'KB',
BrowserVMStats('Gpu'))
I can't say anything about the 'Gpu' string. But adding more stats is always
good.

https://codereview.chromium.org/23449041/diff/1/tools/perf/measurements/endur...
tools/perf/measurements/endure.py:144: AddPoint('v8_memory_allocated', 'KB',
V8StatsSum(_V8_MEMORY_ALLOCATED))
Good one! Unit and trace name were not very consistent anyway.

[qyearsley, 2013-09-25 17:18:29]

Dave, could you take a look at this one?

[dtu, 2013-09-26 21:15:56]

lgtm

[commit-bot: I haz the power, 2013-09-26 21:18:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qyearsley@chromium.org/23449041/1

[commit-bot: I haz the power, 2013-09-26 21:18:03]

Failed to apply patch for tools/perf/measurements/endure.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file tools/perf/measurements/endure.py
  Hunk #1 FAILED at 123.
  1 out of 1 hunk FAILED -- saving rejects to file
tools/perf/measurements/endure.py.rej

Patch:       tools/perf/measurements/endure.py
Index: tools/perf/measurements/endure.py
diff --git a/tools/perf/measurements/endure.py
b/tools/perf/measurements/endure.py
index
da3a1700bd6a9c67eedd6c6bfa970c6370c03f86..385d8cfbc957fb0fd13d7008296cd2856bb414a0
100644
--- a/tools/perf/measurements/endure.py
+++ b/tools/perf/measurements/endure.py
@@ -123,22 +123,23 @@ class Endure(page_measurement.PageMeasurement):
     # DOM nodes and event listeners
     dom_node_count = tab.dom_stats['node_count']
     event_listener_count = tab.dom_stats['event_listener_count']
-    AddPoint('TotalDOMNodeCount', 'nodes', dom_node_count)
-    AddPoint('EventListenerCount', 'events', event_listener_count)
+    AddPoint('dom_nodes', 'count', dom_node_count)
+    AddPoint('event_listeners', 'count', event_listener_count)
 
     # Browser and renderer virtual memory stats
     def BrowserVMStats(statistic_name):
       """Get VM stats from the Browser object in KB."""
       return self._browser.memory_stats[statistic_name].get('VM', 0) / 1024.0
-    AddPoint('BrowserVirtualMemory', 'KB', BrowserVMStats('Browser'))
-    AddPoint('RendererVirtualMemory', 'KB', BrowserVMStats('Renderer'))
+    AddPoint('browser_vm', 'KB', BrowserVMStats('Browser'))
+    AddPoint('renderer_vm', 'KB', BrowserVMStats('Renderer'))
+    AddPoint('gpu_vm', 'KB', BrowserVMStats('Gpu'))
 
     # V8 stats
     def V8StatsSum(counters):
       """Given a list of V8 counter names, get the sum of the values in KB."""
       stats = v8_object_stats.V8ObjectStatsMetric.GetV8StatsTable(tab,
counters)
       return sum(stats.values()) / 1024.0
-    AddPoint('V8BytesCommitted', 'KB', V8StatsSum(_V8_BYTES_COMMITTED))
-    AddPoint('V8BytesUsed', 'KB', V8StatsSum(_V8_BYTES_USED))
-    AddPoint('V8MemoryAllocated', 'KB', V8StatsSum(_V8_MEMORY_ALLOCATED))
+    AddPoint('v8_memory_committed', 'KB', V8StatsSum(_V8_BYTES_COMMITTED))
+    AddPoint('v8_memory_used', 'KB', V8StatsSum(_V8_BYTES_USED))
+    AddPoint('v8_memory_allocated', 'KB', V8StatsSum(_V8_MEMORY_ALLOCATED))

[commit-bot: I haz the power, 2013-10-01 20:42:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qyearsley@chromium.org/23449041/13001

[commit-bot: I haz the power, 2013-10-01 22:43:51]

Retried try job too often on win7_aura for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-10-02 01:08:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qyearsley@chromium.org/23449041/13001

[commit-bot: I haz the power, 2013-10-02 06:43:38]

Change committed as 226400