Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2344903002: Avoid error in testing script if environment is empty. (Closed)

Created:
4 years, 3 months ago by Bill Hesse
Modified:
4 years, 3 months ago
Reviewers:
eernst, Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Avoid error in testing script if environment is empty. BUG= R=eernst@google.com Committed: https://github.com/dart-lang/sdk/commit/34b7fd39dc19794488e0f9e2210a24f3b9ac0e9f

Patch Set 1 #

Patch Set 2 : Use null-aware operator instead. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/testing/dart/test_runner.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Bill Hesse
4 years, 3 months ago (2016-09-15 15:07:46 UTC) #2
Bill Hesse
4 years, 3 months ago (2016-09-15 15:47:55 UTC) #4
eernst
lgtm
4 years, 3 months ago (2016-09-15 16:23:30 UTC) #5
Bill Hesse
4 years, 3 months ago (2016-09-15 16:29:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
34b7fd39dc19794488e0f9e2210a24f3b9ac0e9f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698