tools/testing/dart/test_runner.dart - Issue 2344903002: Avoid error in testing script if environment is empty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_runner.dart

Issue 2344903002: Avoid error in testing script if environment is empty. (Closed)

Patch Set: Use null-aware operator instead. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/testing/dart/test_runner.dart

diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart

index f8570c0200990185da7b3f31b382d74733f81544..3500da98aa2d2b90833c932eecc08bec8ed4bdc2 100644

--- a/tools/testing/dart/test_runner.dart

+++ b/tools/testing/dart/test_runner.dart

@@ -135,7 +135,7 @@ class ProcessCommand extends Command {

String get reproductionCommand {

var env = new StringBuffer();

- environmentOverrides.forEach((key, value) =>

+ environmentOverrides?.forEach((key, value) =>

(io.Platform.operatingSystem == 'windows')

? env.write('set $key=${escapeCommandLineArgument(value)} & ')

: env.write('$key=${escapeCommandLineArgument(value)} '));

« no previous file with comments | « no previous file | no next file » | no next file with comments »