blimp/client/session/blimp_client_session.h - Issue 2344893009: Blimp: relocate thread-unsafe member getter in DropConnection code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/session/blimp_client_session.h

Issue 2344893009: Blimp: relocate thread-unsafe member getter in DropConnection code. (Closed)

Patch Set: wez feedback Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/session/blimp_client_session.h

diff --git a/blimp/client/session/blimp_client_session.h b/blimp/client/session/blimp_client_session.h

index f739f6df4f49f940a2770f5b82e53fbb6272cd9d..8413f1ee65cb8697f00356645b3f0f1f0671ff4e 100644

--- a/blimp/client/session/blimp_client_session.h

+++ b/blimp/client/session/blimp_client_session.h

@@ -86,6 +86,10 @@ class BlimpClientSession

private:

void RegisterFeatures();

+ // Terminates the active connection held by |net_connections_| on the IO

+ // thread. Should be called on the main thread.

+ void DropConnection();

// NetworkEventObserver implementation.

void OnConnected() override;

void OnDisconnected(int result) override;