Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: blimp/client/session/blimp_client_session.h

Issue 2344893009: Blimp: relocate thread-unsafe member getter in DropConnection code. (Closed)
Patch Set: wez feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BLIMP_CLIENT_SESSION_BLIMP_CLIENT_SESSION_H_ 5 #ifndef BLIMP_CLIENT_SESSION_BLIMP_CLIENT_SESSION_H_
6 #define BLIMP_CLIENT_SESSION_BLIMP_CLIENT_SESSION_H_ 6 #define BLIMP_CLIENT_SESSION_BLIMP_CLIENT_SESSION_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 ~BlimpClientSession() override; 79 ~BlimpClientSession() override;
80 80
81 // Notified every time the AssignmentSource returns the result of an attempted 81 // Notified every time the AssignmentSource returns the result of an attempted
82 // assignment request. 82 // assignment request.
83 virtual void OnAssignmentConnectionAttempted(AssignmentRequestResult result, 83 virtual void OnAssignmentConnectionAttempted(AssignmentRequestResult result,
84 const Assignment& assignment); 84 const Assignment& assignment);
85 85
86 private: 86 private:
87 void RegisterFeatures(); 87 void RegisterFeatures();
88 88
89 // Terminates the active connection held by |net_connections_| on the IO
90 // thread. Should be called on the main thread.
91 void DropConnection();
92
89 // NetworkEventObserver implementation. 93 // NetworkEventObserver implementation.
90 void OnConnected() override; 94 void OnConnected() override;
91 void OnDisconnected(int result) override; 95 void OnDisconnected(int result) override;
92 96
93 // BlobImageSerializationProcessor::ErrorDelegate implementation. 97 // BlobImageSerializationProcessor::ErrorDelegate implementation.
94 void OnImageDecodeError() override; 98 void OnImageDecodeError() override;
95 99
96 base::Thread io_thread_; 100 base::Thread io_thread_;
97 101
98 // Receives blob BlimpMessages and relays them to BlobChannelReceiver. 102 // Receives blob BlimpMessages and relays them to BlobChannelReceiver.
(...skipping 24 matching lines...) Expand all
123 127
124 base::WeakPtrFactory<BlimpClientSession> weak_factory_; 128 base::WeakPtrFactory<BlimpClientSession> weak_factory_;
125 129
126 DISALLOW_COPY_AND_ASSIGN(BlimpClientSession); 130 DISALLOW_COPY_AND_ASSIGN(BlimpClientSession);
127 }; 131 };
128 132
129 } // namespace client 133 } // namespace client
130 } // namespace blimp 134 } // namespace blimp
131 135
132 #endif // BLIMP_CLIENT_SESSION_BLIMP_CLIENT_SESSION_H_ 136 #endif // BLIMP_CLIENT_SESSION_BLIMP_CLIENT_SESSION_H_
OLDNEW
« no previous file with comments | « blimp/client/core/blimp_client_context_impl.cc ('k') | blimp/client/session/blimp_client_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698