Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Unified Diff: blimp/client/session/blimp_client_session.h

Issue 2344893009: Blimp: relocate thread-unsafe member getter in DropConnection code. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/session/blimp_client_session.h
diff --git a/blimp/client/session/blimp_client_session.h b/blimp/client/session/blimp_client_session.h
index f739f6df4f49f940a2770f5b82e53fbb6272cd9d..182119cc4d39c9c1cafae9e3ddeb37b988a95b7a 100644
--- a/blimp/client/session/blimp_client_session.h
+++ b/blimp/client/session/blimp_client_session.h
@@ -86,6 +86,10 @@ class BlimpClientSession
private:
void RegisterFeatures();
+ // Terminates the active connection held by |net_connections_|.
+ // May be called on any thread.
Wez 2016/09/17 01:56:31 Eek, let's not leave inviting comments like that i
Kevin M 2016/09/19 17:00:23 Done.
+ void DropConnection();
+
// NetworkEventObserver implementation.
void OnConnected() override;
void OnDisconnected(int result) override;

Powered by Google App Engine
This is Rietveld 408576698