Blimp: relocate thread-unsafe member getter in DropConnection code.

blimp/client/session/blimp_client_session.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_CLIENT_SESSION_BLIMP_CLIENT_SESSION_H_
 #define BLIMP_CLIENT_SESSION_BLIMP_CLIENT_SESSION_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 68 matching lines @@
   ~BlimpClientSession() override;
 
   // Notified every time the AssignmentSource returns the result of an attempted
   // assignment request.
   virtual void OnAssignmentConnectionAttempted(AssignmentRequestResult result,
                                                const Assignment& assignment);
 
  private:
   void RegisterFeatures();
 
+  // Terminates the active connection held by |net_connections_|.
+  // May be called on any thread.

[Wez, 2016/09/17 01:56:31]

Eek, let's not leave inviting comments like that in the codebase :P

I think what we really mean here is just that this should be called on the main
thread, and will trigger the connection-drop on the IO thread, right?

[Kevin M, 2016/09/19 17:00:23]

Done.

+  void DropConnection();
+
   // NetworkEventObserver implementation.
   void OnConnected() override;
   void OnDisconnected(int result) override;
 
   // BlobImageSerializationProcessor::ErrorDelegate implementation.
   void OnImageDecodeError() override;
 
   base::Thread io_thread_;
 
   // Receives blob BlimpMessages and relays them to BlobChannelReceiver.
@@ skipping 24 matching lines @@
 
   base::WeakPtrFactory<BlimpClientSession> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BlimpClientSession);
 };
 
 }  // namespace client
 }  // namespace blimp
 
 #endif  // BLIMP_CLIENT_SESSION_BLIMP_CLIENT_SESSION_H_