Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2344813003: Correct flowThreadTranslationAtOffset() for vertical-rl writing mode. (Closed)

Created:
4 years, 3 months ago by mstensho (USE GERRIT)
Modified:
4 years, 3 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct flowThreadTranslationAtOffset() for vertical-rl writing mode. The problem was that a rectangle was shifted by offsetFromColumnSet() after having been made physical. However, offsetFromColumnSet() is semi-logical (flipped block direction coordinate, like e.g. LayoutBox::m_frameRect), so we need to add it in before flipping the rectangle. This caused all fragmentainer groups but the first one to be translated incorrectly. Committed: https://crrev.com/6fa58d7ef3745c0b84191fd5fdae0e105a5f619e Cr-Commit-Position: refs/heads/master@{#418870}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/offset-top-and-left-nested.html View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/vertical-rl/offset-top-and-left-nested.html View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 3 months ago (2016-09-15 12:00:00 UTC) #4
eae
LGTM
4 years, 3 months ago (2016-09-15 15:16:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344813003/1
4 years, 3 months ago (2016-09-15 15:18:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 15:24:05 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 15:26:50 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6fa58d7ef3745c0b84191fd5fdae0e105a5f619e
Cr-Commit-Position: refs/heads/master@{#418870}

Powered by Google App Engine
This is Rietveld 408576698